STR #1641

FLTK matrix user chat room
(using Element browser app)   FLTK gitter user chat room   GitHub FLTK Project   FLTK News RSS Feed  
  FLTK Apps      FLTK Library      Forums      Links     Login 
 Home  |  Articles & FAQs  |  Bugs & Features  |  Documentation  |  Download  |  Screenshots  ]
 

Return to Bugs & Features | Roadmap 1.1 ]

STR #1641

Application:FLTK Library
Status:1 - Closed w/Resolution
Priority:2 - Low, e.g. a documentation error or undocumented side-effect
Scope:2 - Specific to an operating system
Subsystem:Build Files
Summary:"make clean" doesn't remove all executables
Version:1.1-current
Created By:jeremy_henty
Assigned To:matt
Fix Version:1.1-current (SVN: v5792)
Update Notification:

Receive EMails Don't Receive EMails

Trouble Report Files:


Name/Time/Date Filename/Size top right image
 
#1 jeremy_henty
14:48 Mar 31, 2007
01_clean_00_tests
0k
 
bottom left image   bottom right image

Trouble Report Comments:


Name/Time/Date Text top right image
 
#1 jeremy_henty
14:48 Mar 31, 2007
"make clean" removes the "checkers" and "sudoku" applications but not "blocks". The attached patch fixes this by adding the required line to "test/Makefile".  
 
#2 greg.ercolano
15:18 Mar 31, 2007
I just pulled the latest 1.1.x SVN, and I don't see the problem:

Sat 03/31/07 15:17:14 /usr/local/src/fltk-1.1.x-svn/test
[erco@ontario] ## ROOT ## 212 # ls -la blocks
-rwxr-xr-x  1 root root 217170 Mar 31 15:16 blocks

Sat 03/31/07 15:17:22 /usr/local/src/fltk-1.1.x-svn/test
[erco@ontario] ## ROOT ## 213 # make clean

Sat 03/31/07 15:17:28 /usr/local/src/fltk-1.1.x-svn/test
[erco@ontario] ## ROOT ## 214 # ls -la blocks
ls: blocks: No such file or directory

..as far as I can tell, no binaries are left behind.
 
 
#3 greg.ercolano
15:29 Mar 31, 2007
I see..

"Scope" says all OS's, but looks like this is OSX specific.
(The OSX bundle executable is left behind). My test was on linux.

Scope should probably be 'Specific to an operating system'..
 
 
#4 jeremy_henty
16:34 Mar 31, 2007
Hey, *I*'m building on Linux too! The build creates identical executables in "test/blocks" and "test/blocks.app/Contents/MacOS/blocks", but the clean only removes the first. I have no idea *why* building on Linux creates an executable in a MacOS directory, but it does!  
 
#5 greg.ercolano
18:41 Mar 31, 2007
Yeow, you're right.

And it's a linux binary alright, too.. file(1) says so.
(ie. its *not* a 'leftover' from a previous MacOS build)

Apparently the build instructions for 'blocks' includes
an 'install' command that puts the blocks executable in
the .app dir regardless of platform; on fedora3:

----

# pwd
/usr/local/src/fltk-1.1.x-svn/test

# make blocks
echo Compiling blocks.cxx...
Compiling blocks.cxx...
g++ -I..     -Os -Wall -Wunused -Wno-format-y2k  -fno-exceptions -fno-strict-aliasing      -I/usr/X11R6/include -c blocks.cxx
echo Linking blocks...
Linking blocks...
g++  -Os -Wall -Wunused -Wno-format-y2k  -fno-exceptions -fno-strict-aliasing  -L/usr/X11R6/lib  blocks.o -o blocks -lasound ../lib/libfltk.a -ldl -lm  -lXext -lX11
/usr/bin/install -c -m 755 blocks blocks.app/Contents/MacOS
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
: blocks ../FL/mac.r

----

Looks like test/Makefile at fault here; shouldn't be copying stuff into the .app dirs unless it's an OSX build.

Same problem for 'checkers' and 'sudoku' targets (on fedora3):

----
# make sudoku
[..]
/usr/bin/install -c -m 755 sudoku sudoku.app/Contents/MacOS
: sudoku ../FL/mac.r

# make checkers
[..]
/usr/bin/install -c -m 755 checkers checkers.app/Contents/MacOS
: checkers ../FL/mac.r
----
 
 
#6 matt
13:23 May 01, 2007
Fixed in Subversion repository.  
bottom left image   bottom right image

Return to Bugs & Features ]

 
 

Comments are owned by the poster. All other content is copyright 1998-2022 by Bill Spitzak and others. This project is hosted by The FLTK Team. Please report site problems to 'erco@seriss.com'.