| | [ Return to Bugs & Features ]
STR #3327
| Application: | FLTK Library |
|---|
| Status: | 1 - Closed w/Resolution |
|---|
| Priority: | 4 - High, e.g. key functionality not working |
|---|
| Scope: | 3 - Applies to all machines and operating systems |
|---|
| Subsystem: | Core Library |
|---|
| Summary: | Public members Fl::awake_ring_*_ should be private |
|---|
| Version: | 1.4-feature |
|---|
| Created By: | AlbrechtS |
|---|
| Assigned To: | AlbrechtS |
|---|
| Fix Version: | 1.4.0 |
|---|
| Fix Commit: | df059de37e776874cf1fbe303141764f1c8fc34e |
|---|
| Update Notification: | |
|---|
Trouble Report Files:
No files
Trouble Report Comments:
| |
| #1 | AlbrechtS
11:55 Sep 13, 2016 |
| Referring to STR #3223, comments #4, #5, and #9:
http://www.fltk.org/str.php?L3223
#4 (me): Fl::awake_ring_head_, Fl::awake_ring_head_, etc. should be private. These member variables are currently public.
#5 (Ian): In 1.4.x we could implement my "fix" by adding a "check ring buffer" method in FL_lock.cxx, rather than doing it in fl_win32.cxx as my current plan does...
#9 (me): Making these member variables private should be done in 1.4.0. We need to add one or more accessor methods (read-only getter's). The fact that a lock is used internally makes it IMHO _necessary_ to prohibit direct access. WRT ABI: if anybody really used these variables we must break that code. Really. We can still think about which getter methods we need to help. | |
| |
| #2 | AlbrechtS
12:12 Sep 13, 2016 |
| Changed priority to 4 (high) because the potential change would break the ABI. | |
| |
| #3 | AlbrechtS
14:12 Nov 26, 2022 |
| This STR has been moved to GitHub issue #559:
https://github.com/fltk/fltk/issues/559
Further discussions should be done there... | |
| |
| #4 | AlbrechtS
17:54 Jan 19, 2023 |
| Fixed in Git repository.
See GitHub issue #559 (link above). | |
[ Return to Bugs & Features ]
|
| |
FLTK Apps 
