FLTK logo

Re: [fltk/fltk] This commit fixes the white corners of menus under macOS. (PR #503)

FLTK matrix user chat room
(using Element browser app)   FLTK gitter user chat room   GitHub FLTK Project   FLTK News RSS Feed  
  FLTK Apps      FLTK Library      Forums      Links     Login 
 All Forums  |  Back to fltk.issues  ]
 
Previous Message ]New Message | Reply ]Next Message ]

Re: [fltk/fltk] This commit fixes the white corners of menus under macOS. (PR #503) Albrecht Schlosser Sep 24, 2022  
 

@ggarra13 wrote:

… the problem is also there on other platforms. You just don’t see it as windows are created blank by default there.

I agree that this might be an issue on other platforms as well (pixels that are never drawn). Is it possible to make a short and complete demo program that would show the issue on all platforms, for instance by setting a background color explicitly? One option to do so is using the command line switch -bg "color", e.g. -bg '#554433' for a dark background.

Another important point to consider: the proposed patch changes box drawing code which is applied all over the FLTK GUI, not only for menus. Backgrounds can have more than just one color, for instance the tiled stipple pattern of the plastic scheme or even a user defined image. In such cases the patch might cause other unwanted artifacts.

That all said, IMO the proposed patch is not a proper solution of this issue. A correct patch would draw the extra background pixels only:

  • on the macOS platform (maybe) and
  • in the context of menus (menu windows)

Otherwise unwanted artifacts would likely cause another regression.

Disclaimer: I didn't test anything, these are just my thoughts while reading about this issue.


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <fltk/fltk/pull/503/c1256908285@github.com>

Direct Link to Message ]
 
     
Previous Message ]New Message | Reply ]Next Message ]
 
 

Comments are owned by the poster. All other content is copyright 1998-2024 by Bill Spitzak and others. This project is hosted by The FLTK Team. Please report site problems to 'erco@seriss.com'.