FLTK logo

STR #2254

FLTK matrix user chat room
(using Element browser app)   FLTK gitter user chat room   GitHub FLTK Project   FLTK News RSS Feed  
  FLTK Apps      FLTK Library      Forums      Links     Login 
 Home  |  Articles & FAQs  |  Bugs & Features  |  Documentation  |  Download  |  Screenshots  ]
 

Return to Bugs & Features | Roadmap 2.0 | SVN ⇄ GIT ]

STR #2254

Application:FLTK Library
Status:1 - Closed w/Resolution
Priority:3 - Moderate, e.g. unable to compile the software
Scope:2 - Specific to an operating system
Subsystem:Build Files
Summary:fluid Makefile uses system fltk2-confing instead of the one in build tree
Version:2.0-current
Created By:mnowak
Assigned To:AlbrechtS
Fix Version:2.0-current (SVN: v6920)
Update Notification:

Receive EMails Don't Receive EMails

Trouble Report Files:

No files


Trouble Report Comments:


Name/Time/Date Text  
 
#1 mnowak
01:59 Sep 17, 2009
In Fedora review request we have this patch:

--- fluid/Makefile      2008-08-05 01:03:58.000000000 +0200
+++ fluid/Makefile.new  2008-12-21 21:04:13.719528722 +0100
@@ -134,7 +134,8 @@ install:
        -$(MKDIR) $(DESTDIR)$(bindir)
        $(CP) $(FLUID) $(DESTDIR)$(bindir)/fluid2$(EXEEXT)
        $(STRIP) $(DESTDIR)$(bindir)/fluid2$(EXEEXT)
-       $(bindir)/fltk2-config --post $(DESTDIR)$(bindir)/fluid2$(EXEEXT)
+       chmod +x ../fltk2-config
+       ../fltk2-config --post $(DESTDIR)$(bindir)/fluid2$(EXEEXT)
        $(CHMOD) 755 $(DESTDIR)$(bindir)/fluid2$(EXEEXT)


Unless we wanna fail like this:

...
Installing FLUID2 in /usr/bin...
mkdir -p /home/newman/rpmbuild/BUILDROOT/fltk2-2.0.x-0.17.r6858.fc12.x86_64/usr/bin
cp fluid2 /home/newman/rpmbuild/BUILDROOT/fltk2-2.0.x-0.17.r6858.fc12.x86_64/usr/bin/fluid
2
strip /home/newman/rpmbuild/BUILDROOT/fltk2-2.0.x-0.17.r6858.fc12.x86_64/usr/bin/fluid
2
/usr/bin/fltk2-config --post /home/newman/rpmbuild/BUILDROOT/fltk2-2.0.x-0.17.r6858.fc12.x86_64/usr/bin/fluid
2
make[1]: /usr/bin/fltk2-config: Command not found
make[1]: *** [install] Error 127
make[1]: Leaving directory `/home/newman/rpmbuild/BUILD/fltk-2.0.x-r6858/fluid'
make: *** [install] Error 2

Consider adding it to snapshots.
 
 
#2 AlbrechtS
04:44 Sep 17, 2009
A few notes:

(1) A better solution would be to add $(DESTDIR) for fltk2-config --post, because this ought to be installed already at this stage, i.e.

-   $(bindir)/fltk2-config --post $(DESTDIR)$(bindir)/fluid2$(EXEEXT)
+   ${DESTDIR}$(bindir)/fltk2-config --post $(DESTDIR)$(bindir)/fluid2$(EXEEXT)

(2) Why is your "../fltk2-config" not executable in the first place? Mine is, and IMHO it should be. Are you using a non-standard umask for configuring FLTK-2?

(3) FLTK-2 is unsupported alpha software without an official release. Is this going to be included in fc12?
 
 
#3 mnowak
05:04 Sep 17, 2009
Thanks for the reply.

Ad 1) You're right, I've changed it here.

Ad 2) The patch is several months old and was created against older snapshot; now it's fixed for me too.

Ad 3) Nope. We hoped to FLTK2 stabilize soon, so, we can include Dillo2 in Fedora -- but that's not likely to happen any time soon.
 
 
#4 AlbrechtS
04:02 Oct 22, 2009
Fixed in Subversion repository.  
     

Return to Bugs & Features ]

 
 

Comments are owned by the poster. All other content is copyright 1998-2024 by Bill Spitzak and others. This project is hosted by The FLTK Team. Please report site problems to 'erco@seriss.com'.