| | [ Return to Bugs & Features | Roadmap 1.1 | SVN ⇄ GIT ]
STR #924
| Application: | FLTK Library |
|---|
| Status: | 1 - Closed w/Resolution |
|---|
| Priority: | 3 - Moderate, e.g. unable to compile the software |
|---|
| Scope: | 3 - Applies to all machines and operating systems |
|---|
| Subsystem: | Core Library |
|---|
| Summary: | fl_push_matrix() is not safe |
|---|
| Version: | 1.1-current |
|---|
| Created By: | oksid |
|---|
| Assigned To: | matt |
|---|
| Fix Version: | 1.1-current (SVN: v4417) |
|---|
| Update Notification: | |
|---|
Trouble Report Files:
Trouble Report Comments:
| |
| #1 | oksid
07:10 Jun 28, 2005 |
| fl_push_matrix() and fl_pop_matrix() are not safe due to the use of a static array.
The attached fl_vertex.cxx patch solves the problem by using dynamic array. | |
| |
| #2 | mike
08:45 Jun 28, 2005 |
| I think I'd rather just increase the size of the stack to 32 and check for overflow and underflow, spitting out an error via Fl::error() when the matrix stack goes out-of-bounds.
Otherwise we risk having a buggy program using up all available memory by not popping all of the matrices they push... | |
| |
| #3 | matt
07:31 Jul 14, 2005 |
| Added code according to Mike's suggestion. Stack depth is now 32. | |
[ Return to Bugs & Features ]
|
| |
