STR #3327

GitHub FLTK Project   FLTK News RSS Feed  
  FLTK Apps      FLTK Library      Forums      Links     Login 
 Home  |  Articles & FAQs  |  Bugs & Features  |  Documentation  |  Download  |  Screenshots  ]
 

Return to Bugs & Features | Post Text | Post File | Prev | Next ]

STR #3327

Application:FLTK Library
Status:5 - New
Priority:4 - High, e.g. key functionality not working
Scope:3 - Applies to all machines and operating systems
Subsystem:Core Library
Summary:Public members Fl::awake_ring_*_ should be private
Version:1.4-feature
Created By:AlbrechtS
Assigned To:AlbrechtS
Fix Version:Unassigned
Update Notification:

Receive EMails Don't Receive EMails

Trouble Report Files:

Post File ]

No files


Trouble Report Comments:

Post Text ]
Name/Time/Date Text top right image
 
#1 AlbrechtS
11:55 Sep 13, 2016
Referring to STR #3223, comments #4, #5, and #9:
http://www.fltk.org/str.php?L3223

#4 (me): Fl::awake_ring_head_, Fl::awake_ring_head_, etc. should be private. These member variables are currently public.

#5 (Ian): In 1.4.x we could implement my "fix" by adding a "check ring buffer" method in FL_lock.cxx, rather than doing it in fl_win32.cxx as my current plan does...

#9 (me): Making these member variables private should be done in 1.4.0. We need to add one or more accessor methods (read-only getter's). The fact that a lock is used internally makes it IMHO _necessary_ to prohibit direct access. WRT ABI: if anybody really used these variables we must break that code. Really. We can still think about which getter methods we need to help.
 
 
#2 AlbrechtS
12:12 Sep 13, 2016
Changed priority to 4 (high) because the potential change would break the ABI.  
bottom left image   bottom right image

Return to Bugs & Features | Post Text | Post File ]

 
 

Comments are owned by the poster. All other content is copyright 1998-2021 by Bill Spitzak and others. This project is hosted by The FLTK Team. Please report site problems to 'erco@seriss.com'.