[ Return to Bugs & Features | Post Text | Post File | Prev | Next ]
|Status:||5 - New|
|Priority:||4 - High, e.g. key functionality not working|
|Scope:||3 - Applies to all machines and operating systems|
|Summary:||Public members Fl::awake_ring_*_ should be private|
Trouble Report Files:
[ Post File ]
Trouble Report Comments:
[ Post Text ]
11:55 Sep 13, 2016
|Referring to STR #3223, comments #4, #5, and #9: |
#4 (me): Fl::awake_ring_head_, Fl::awake_ring_head_, etc. should be private. These member variables are currently public.
#5 (Ian): In 1.4.x we could implement my "fix" by adding a "check ring buffer" method in FL_lock.cxx, rather than doing it in fl_win32.cxx as my current plan does...
#9 (me): Making these member variables private should be done in 1.4.0. We need to add one or more accessor methods (read-only getter's). The fact that a lock is used internally makes it IMHO _necessary_ to prohibit direct access. WRT ABI: if anybody really used these variables we must break that code. Really. We can still think about which getter methods we need to help.
12:12 Sep 13, 2016
|Changed priority to 4 (high) because the potential change would break the ABI. ||
[ Return to Bugs & Features | Post Text | Post File ]