| |
| #1 | greg.ercolano
21:19 May 05, 2013 |
| This STR will be a list of issues that need to be addressed
as it's too much for email. | |
| |
| #2 | greg.ercolano
21:36 May 05, 2013 |
| 0) Update the newsgroup stickies.
See email to Albrecht 5/4/13 11:24a
1) Weekly snapshots of SVN.
See email to Duncan 05/05/13 21:11 for hints.
2) (DONE) Minimal nightly cron backup of svn and sql (prev behavior)
Let's see if it runs w/out errors tonight 5/6/13.
(Yesterday failed because mysqldump was not in cron's PATH)
3) Nightly backups
See email to Albrecht 05/05/13 14:40 for hints, but basically:
fltk.sql \__ what we have now..
svn.tar /
newsgroups.tar -- all the newsgroup articles
str.tar -- all the str attachments
backend.tar -- everything else, excluding the above
Perhaps newsgroups/str/backend can be weekly, as they're
big and slow.
4) Fixes to newsgroup.php searches for speed.
(Current mods work, but are slow. Avoid search msg viewer
having to redo searches by just using absolute msg view instead,
and remove Prev/Next)
See fltk.coredev post to Albrecht 5/5/13 20:17
5) Change SVN .authz for "applications" to allow dev r/w access
and public read-only, eg:
[applications:/]
@devteam = rw
* = r
See email to Albrecht 05/05/13 14:52
6) Document all these mechanisms in adm/README.html
7) Figure out how to let distros know about new FLTK releases.
If by mailing list, which address? Same for gmane.
8) RSS feeds -- check they work, make sure they update. Add rss link
to main page if not already.
9) fltk.announce -- newsgroup needs a way for devs to post,
and need to attach a read-only mailing list (google groups?)
10) (DONE) Verify newsgroup's Reply-To are working correctly.
11) If newsgroups.php stable, check in all mods to date to www.
.. | |
| |
| #3 | greg.ercolano
21:48 May 05, 2013 |
| 12) There might be something wrong with the fltk.commit hook scripts;
12a) See r698 on 04/05/13 which has a truncated entry; log message
is truncated, and there's no diff info in the commit at all.
Check the svn log for the website.
Might be a '.' got in the mail and terminated it early?
Investigate.
12b) The website commit is showing as [Library] instead of [WWW].
I think 'commit-email' is missing logic to relabel the Subject. | |
| |
| #4 | greg.ercolano
22:02 May 05, 2013 |
| 13) Developer "Web Site" menu -- not all working.
(?) Update web site from SVN
(?) Commit database changes to the Subversion repository
(OK) Manage the site bugs
(OK) Download the nightly backups
(?) Upload distribution files
(ERROR) View the site usage/traffic reports
Is 'distribution' files "release files"? ie. how devs upload
new releases? Look at code, test.. | |
| |
| #5 | greg.ercolano
22:05 May 05, 2013 |
| 14) Find out what Mike had for robots.txt.
Google et al are probably indexing tar files, which is bad. | |
| |
| #6 | greg.ercolano
22:12 May 05, 2013 |
| 15) Document the release process.
Refer to Matt/Mike.
Once determined, document details for dev access only,
and later make a script to automate as much of this behavior
as possible, and provide to devs.
Perhaps this already exists (Website -> Upload distrib files)?
Should automate making announcement on fltk.announce, RSS feed,
main page links, etc etc. | |
| |
| #7 | greg.ercolano
02:42 May 06, 2013 |
| 16) (DONE) Problem Duncan reported: [Next msg] not working right
in newsgroups when viewing close to last articles. (Email from Duncan
05/05/13 11:36a)
17) Problem Duncan reported: "Unread messages" feature not working right.
Supposed to remember highest article viewed, or some such. | |
| |
| #8 | greg.ercolano
06:13 May 06, 2013 |
| 4b) While tweaking newsgroups.php, change it so searches use a URL
(that can be pasted in emails). Beware of quoting the search string
appropriately to protect it from + and ? argument separation,
and other argument loopholes. See post on fltk.coredev to Albrecht
05/06/13 6:12a. | |
| |
| #9 | greg.ercolano
08:39 May 07, 2013 |
| > 4) Fixes to newsgroup.php searches for speed.
Done.
Modified searches so that the "search results" page
has links directly to the articles, so that clicking them
quickly shows the article (instead of redoing the slow search)
This optimization let's one read articles from search results
quickly, but the [Next] and [Previous] buttons on the article
viewer page doesn't browse the search results, it browses article
numbers incrementally.
Also: upgraded to a new version of newsd that avoids linear
oriented article directories, which optimizes certain NNTP
operations, such as "XOVER <range>", where <range> is a range
that isn't the entire newsgroup. | |
| |
| #10 | greg.ercolano
08:44 May 07, 2013 |
| > 14) Find out what Mike had for robots.txt.
> Google et al are probably indexing tar files, which is bad.
DONE: Modified robots.txt to Disallow /pub and /site.
/pub is full of tar files, no reason for search engines
to frob around with those. | |
| |
| #11 | greg.ercolano
08:47 May 07, 2013 |
| > 12b) The website commits are showing as [Library] instead of [WWW]
> in fltk.commit.
DONE: Modified adm/bin/commit-email. Needs testing. | |
| |
| #12 | greg.ercolano
17:41 May 07, 2013 |
| 18) See if dav_svn.passwd can be connected to data/passwd
To re-enable developer access to the old password info.
See email from Albrecht 5/7/13 17:05 | |
| |
| #13 | greg.ercolano
01:09 May 08, 2013 |
| > 5) Change SVN so "applications" is r/w to devs, ro to public
DONE.
Updated list to date:
0) Update the newsgroup stickies.
1) Weekly snapshots of SVN
2) (DONE) Nightly cron backups of svn and sql (prev behavior)
3) Additional nightly backups: newsgroups, str, backend
4) (DONE) Fixes to newsgroup searches
5) (DONE) Change SVN so "applications" is r/w to devs, ro to public
6) Document fltk website mechanisms in adm/README.html
7) Figure out how to let distros know about new FLTK releases.
8) RSS feeds -- check they work, rss link on main page?
9) fltk.announce -- newsgroup needs a way for devs to post
10) (DONE) Verify newsgroup's Reply-To are working correctly.
11) If newsgroups.php stable, check in all mods to date to www.
12) Problems with fltk.commit hook scripts;
12a) See r698 on 04/05/13 which has a truncated entry
12b) (DONE) The website commit is showing as [Library] instead of [WWW].
13) Developer "Web Site" menu -- not all working.
14) (DONE) Modify robots.txt to ignore tar dirs
15) Document release process
16) (DONE) Problem Duncan reported: [Next msg] not working right
17) Problem Duncan reported: "Unread messages" feature not working
18) See if dav_svn.passwd can connect to data/passwd (Mike says yes) | |
| |
| #14 | greg.ercolano
16:48 May 08, 2013 |
| > 13) Developer "Web Site" menu -- not all working.
DONE.
OK, added strike-out text to the menu items that are disabled.
Didn't try 'Upload distribution files'; afraid to test it
in case it overwrites something important.
(DISABLED) Update web site from SVN
(DISABLED) Commit database changes to the Subversion repository
(OK) Manage the site bugs
(OK) Download the nightly backups
(DISABLED) Upload distribution files
(DISABLED) View the site usage/traffic reports | |
| |
| #15 | greg.ercolano
20:04 May 08, 2013 |
| > 8) RSS feeds -- check they work, rss link on main page?
WIP
Looks like the site uses fltk.org/index.rss in the headers,
but there's no RSS feed link on the main page.
Should probably add the orange RSS feed icon to the main page, e.g.
ie. http://www.seriss.com/rush/gifs/rss-feed-icon.png
..and then try to trigger populating it. (Article dbase?) | |
| |
| #16 | greg.ercolano
11:42 May 19, 2013 |
| > 3) Additional nightly backups: newsgroups, str, backend..
Done.
> 0) Update stickies
Done. | |
| |
| #17 | greg.ercolano
11:47 May 19, 2013 |
| > 11) If newsgroups.php stable, check in all mods to date to www.
> 12) Problems with fltk.commit hook scripts;
> 18) See if dav_svn.passwd can connect to data/passwd (Mike says yes)
These three done.
What's left:
1) Weekly snapshots of SVN
6) Document fltk website mechanisms in adm/README.html
7) Figure out how to let distros know about new FLTK releases.
8) RSS feeds -- check they work, rss link on main page?
9) fltk.announce -- newsgroup needs a way for devs to post
12a) See r698 on 04/05/13 which has a truncated entry
13) Developer "Web Site" menu -- not all working.
15) Document release process
17) Problem Duncan reported: "Unread messages" feature not working | |
| |
| #18 | greg.ercolano
11:55 May 28, 2013 |
| 19) Some articles are so large they can't be loaded into memory
with the current algorithm (the HTTP connection times about before
it finishes). Example:
http://www.fltk.org/newsgroups.php?s9466+gfltk.commit
Change the 'show_message()' PHP code to show the document
as it is loaded (a line at a time) instead of first loading
it into a string, and then later displaying the string. | |
| |
| #19 | greg.ercolano
02:23 Jun 02, 2013 |
| 19) Fixed in r708.
Changed code to display message body directly to browser
(instead of loading into a variable, causing timeouts before
msg could be displayed)
BTW: correct link to large article is:
http://www.fltk.org/newsgroups.php?s9466+gfltk.commit+v9466
Also fixed a problem with charset on Safari+Chrome;
the motd from the crash was messing up the newgroup character
encodings.
Also added some hacks to try to minimize the =20 and = stuff
by adding detection of 'printed quotable' content type in headers,
and applying replaces accordingly. Could be more robust to handle
other =## codes. | |
| |
| #20 | greg.ercolano
02:28 Jun 02, 2013 |
| 20) Searches in forums are really slow. Add an indexer. (WIP).
The todo list so far:
1) Weekly snapshots of all backups (SVN..) to offsite storage
6) Document fltk website mechanisms in adm/README.html
7) Figure out how to let distros know about new FLTK releases.
8) RSS feeds -- check they work, rss link on main page?
9) fltk.announce -- newsgroup needs a way for devs to post
12a) See r698 on 04/05/13 which has a truncated entry
13) Developer "Web Site" menu -- not all working.
15) Document release process
17) Problem Duncan reported: "Unread messages" feature not working
20) Searches in forums are really slow. Use an indexer. (WIP) | |
| |
| #21 | greg.ercolano
10:27 Sep 12, 2013 |
| 1) Weekly snapshots of all backups (SVN..) to offsite storage
This one has been done; about a month or so ago I've been
pulling the website and svn snapshots via cron.
Also, Albrecht has been doing the same.
So we both have copies running; I've dedicated a large
hard drive to keep all the backup files.
What would be good is if my backup pulling code forced
its output log into the fltk.admlog group, so that the
backup success/failure can be viewed easily. | |
| |
| #22 | greg.ercolano
04:04 Sep 16, 2013 |
| 13) Developer "Web Site" menu -- not all working.
Re-enabled the "Upload distribution files" submenu,
but have not tested it.
Devs will needs this for the next FLTK release (1.3.3).
Assuming you've used it before, let me know if there's
any trouble using it. | |
| |
| #23 | greg.ercolano
18:19 Sep 18, 2013 |
| 6) Document fltk website mechanisms in adm/README.html
Done.
Updated with new info on how fltk.org works.
This file has been renamed adm/README.txt.
The updated info should appear in the next nightly backup
of the administration tar ball, i.e. http://www.fltk.org/site/fltk-adm.tar.bz2 | |
| |
| #24 | greg.ercolano
18:31 Sep 18, 2013 |
| 12a) See r698 on 04/05/13 which has a truncated entry
This is now a non-issue; www mods are not logged.
What's left:
7) Figure out how to let distros know about new FLTK releases.
8) RSS feeds -- check they work, rss link on main page?
9) fltk.announce -- newsgroup needs a way for devs to post
15) Document release process
17) Problem Duncan reported: "Unread messages" feature not working
20) Searches in forums are really slow. Use an indexer. (WIP)
Regarding #7, apparently Mike said on 05/01/13:
I used to post announcements to Freshmeat.net (now Freecode.com),
but I think the packagers watch the [fltk.org] site.
This should be documented in the CMP, along with whatever
we do to solve #9 and #15. | |
| |
| #25 | greg.ercolano
07:03 Feb 06, 2014 |
| Adding a new items:
21) STR activity (bugs) should be sent to the fltk.coredev group
22) Remove or shrink the crash notice on main page
23) Possibly redo the main page; follow thread on fltk.general:
"FLTK awake or Lock/unlock doesn't work" from Feb 5th 2014 onward.
So the list to date is:
7) Figure out how to let distros know about new FLTK releases.
8) RSS feeds -- check they work, rss link on main page?
9) fltk.announce -- newsgroup needs a way for devs to post
15) Document release process
17) Problem Duncan reported: "Unread messages" feature not working
20) Searches in forums are really slow. Use an indexer. (WIP)
21) STR activity (bugs) should be sent to the fltk.coredev group
22) Remove or shrink the crash notice on main page
23) Possibly redo the main page; follow thread on fltk.general:
"FLTK awake or Lock/unlock doesn't work" from Feb 5th 2014 onward. | |
| |
| #26 | AlbrechtS
13:06 Feb 06, 2014 |
| -1 on 21) "STR activity (bugs) should be sent to the fltk.coredev group"
We have fltk.bugs for this, and I wouldn't like to have this traffic twice (or intermixed with discussions in fltk.coredev).
+1 on 22) and 23). | |
| |
| #27 | greg.ercolano
13:35 Feb 06, 2014 |
| > -1 on 21)
OK -- I seemed to recall some STRs were sent to fltk.development,
though looking now, apparently it was just "RFE" status STR's.
Right now I have that gateway email shut off.
Should I revise to /just/ restore the RFE status STR emails to fltk.coredev, or is it better to not have any crosstalk between
the STR system and fltk.coredev? | |
| |
| #28 | AlbrechtS
10:55 Feb 09, 2014 |
| I'm not sure. I tend to mail (post) everything to fltk.bugs, particularly since the status can change from STR (bug) to RFE and vice versa. This is not what we had before the server crash, but maybe it's better to separate the bug tracking system from user-written (google) mails, independent of the status a STR has. | |
| |
| #29 | greg.ercolano
10:50 Jun 24, 2015 |
| I think these items are solved:
8) RSS feeds -- check they work, rss link on main page?
(DONE) Added an rss icon to the html header,
and a symlink that directs fltk-rss.xml -> index.rss.
There's also stuff for RSS feeds built into the fltk main page's
headers that have been there all along (not sure how they work)..
15) Document release process
(DONE) This is now part of the CMP.
21) STR activity (bugs) should be sent to the fltk.coredev group
(DONE) This RFE is being withdrawn as per above.
22) Remove or shrink the crash notice on main page
(DONE) This was done.
..which leaves these items:
9) fltk.announce -- newsgroup needs a way for devs to post
17) Problem Duncan reported: "Unread messages" feature not working
20) Searches in forums are really slow. Use an indexer. (WIP)
23) Possibly redo the main page; follow thread on fltk.general:
"FLTK awake or Lock/unlock doesn't work" from Feb 5th 2014 onward. | |
| |
| #30 | AlbrechtS
16:02 Dec 08, 2018 |
| OK, taking a look at the todo's in this STR to see if anything is still open / pending after we moved to Seriss and meanwhile again away to another server on Dec 01, 2018.
9) fltk.announce -- newsgroup needs a way for devs to post
DONE.
17) Problem Duncan reported: "Unread messages" feature not working
DONE. Working again on the new server, fixed by Greg.
..which leaves these items:
20) Searches in forums are really slow. Use an indexer. (WIP)
23) Possibly redo the main page; follow thread on fltk.general:
"FLTK awake or Lock/unlock doesn't work" from Feb 5th 2014 onward.
Is there still anything we can do for items 20 and 23?
I have no idea what item 23 means...
Can we close this STR? | |
| |
| #31 | greg.ercolano
16:29 Dec 08, 2018 |
| 23) refers to a thread in FLTK general (with that subject)
which suggested some improvements to the main page..
some have been solved, some not.
The suggestions were, to summarize:
a) Make the FLTK cheat page part of the FLTK website
and make it editable so other devs can add to it.
b) Too much noise from the snapshot autoposts.
I think I fixed this by limiting the noise to a single post. | |
| |
| #32 | AlbrechtS
06:55 May 15, 2021 |
| I believe point
20) Searches in forums are really slow. Use an indexer. (WIP)
is DONE since you (Greg) recently (months ago?) changed newsgroups.php to limit the searches (no indexer though AFAICT).
After all we seem to have only one open issue:
23a) Make the FLTK cheat page part of the FLTK website
and make it editable so other devs can add to it.
I believe your cheat sheet can be (and is) found easily by users. I would propose to not make it "part of the FLTK website" but rather add a link or use a "sticky article" so users can find it even more easily.
If you agree I think it's best if you write a short article with a link to your page, but I could also do it if you like.
Since this is the only remaining point we could then close this STR! | |
| |
| #33 | greg.ercolano
09:09 May 15, 2021 |
| I think this item fell out of the list somehow:
7) Figure out how to let distros know about new FLTK releases.
If by mailing list, which address? Same for gmane. | |
| |
| #34 | greg.ercolano
09:15 May 15, 2021 |
| Also, the RSS feed still seems broken, at least in firefox.
When I go here: https://www.fltk.org/fltk-rss.xml
..it complains about missing style information.
I checked CNN's RSS feed which looks correct in firefox:
http://rss.cnn.com/rss/cnn_topstories.rss
..so I should probably figure out what the differences are by comparing the source, and apply tweaks to our RSS generator. | |
| |
| #35 | AlbrechtS
10:48 May 15, 2021 |
| Regarding 7) Figure out how to let distros know about new FLTK releases.
ISTR that we discussed this in the past (maybe in fltk.coredev?) and decided that this is not necessary. IIRC it was said that distros (i.e. maintainers) are watching their sources, hence we don't need to do anything except our normal mailing (which I did today).
I propose to drop point 7). | |
| |
| #36 | AlbrechtS
10:58 May 15, 2021 |
| Regarding RSS feed: I see the difference FLTK vs. CNN, and yes, I get the same error message and the source info from our rss file with Firefox and Google Chrome. Safari, BTW, says "No RSS reader is installed.". I didn't bother to install one...
However, I've seen similar issues with other RSS feeds and I installed a Firefox plugin ("FeedBro") and the RSS feed works like a charm with this plugin. The plugin shows a notification of all feeds I registered and this works fine.
So ... whatever the reason is why it doesn't work, it is not entirely broken. If you know how to fix it, ... | |
| |
| #37 | greg.ercolano
11:53 May 15, 2021 |
| Re: OK, item #7 done.
Item #8 (RSS), I know the RSS format changed in some significant way.
Perhaps what I can do is continue to provide the old format in .xml, and provide the "new" format in .rss and modify the RSS icon to link to that, that might be a better result for people. | |
| |
| #38 | AlbrechtS
12:01 May 15, 2021 |
| I'd be glad if you could do this, I don't know where to start.
Just a note: Wikipedia says in https://en.wikipedia.org/wiki/RSS :
"Internet media type: application/rss+xml (registration not finished)"
[1] https://tools.ietf.org/id/draft-nottingham-rss-media-type-00.txt
Maybe we'd need to provide the media type in the web server message? | |
| |
| #39 | greg.ercolano
12:16 May 15, 2021 |
| I installed the "Livemarks" Firefox add on from here:
https://addons.mozilla.org/en-US/firefox/addon/livemarks/
..and suddenly our FLTK rss feeds look normal again.
That's Firefox's current "Recommended" RSS reader, according to their curated addons page here:
https://addons.mozilla.org/en-US/firefox/collections/5975439/feed-readers/
Apparently firefox removed their RSS handler in version 64.0 back in 2018, which is why our feed looks like "an error" now. I just find it interesting that e.g. CNN's RSS looks OK without the plugin.
We use RSS 1.0 (the "RDF" namespace), whereas I think the newer RSS 2.0 format is perhaps what CNN is using and is maybe better supported "out of the box" for browsers. | |
| |
| #40 | greg.ercolano
12:18 May 15, 2021 |
| Attaching a screenshot (livemarks.jpg) showing firefox before and after reading the current fltk rss news feed.
Looks normal with that add on, so perhaps "solved", but would like to explore additionally exporting the RSS feed in 2.0 format, and see if there's some way to support both. | |
| |
| #41 | AlbrechtS
13:47 May 15, 2021 |
| Livemarks works fine here too, but there's still other browsers having issues as seen before (Chrome, Safari).
> would like to explore additionally exporting the RSS feed in 2.0 format
I'd appreciate if you could find a better solution. TIA. | |
| |
| #42 | AlbrechtS
14:21 May 15, 2021 |
| FTR: from https://en.wikipedia.org/wiki/RSS#Current_usage
"RSS support was removed in OS X Mountain Lion's versions of Mail and Safari, although the features were partially restored in Safari 8.[34][35] Mozilla removed RSS support from Mozilla Firefox version 64.0, joining Google Chrome and Microsoft Edge which do not include RSS support, thus leaving Internet Explorer as the last major browser to include RSS support by default." | |
| |
| #43 | greg.ercolano
22:07 May 15, 2021 |
| Thanks, this may save me a lot of time actually.
Good grief, sounds like the browsers are just dropping default support for a perfectly simple and useful protocol that websites use but browsers don't support.
I guess the CNN rss feed must /look/ like it's working because CNN must have some automation that looks at the HTTP request to determin whether to send the RSS data, or send an HTML version of it that "looks nice" if the browser doesn't support it.
Easy to prove; I grabbed a snapshot of the CNN rss feed with curl(1) to a foo.xml, look at the result to verify it's RSS data, then try to open that static content in those same browsers, and it "looks broken", and nothing like one sees if browsing to the RSS link directly; the latter must be "faked" RSS.
Well I don't think trying to make the browsers look good by doing their job for them by translating the RSS into HTML, so unless there's some other way, it's just "too bad" for users with browsers that dropped RSS support. | |
| |
| #44 | AlbrechtS
05:52 May 16, 2021 |
| Hmm, sounds as if we could close the STR then...
However, here's another option to add an "atom feed" which appears to be the (one) "new standard". I uploaded three files as a proof of concept:
- RSS_Atom_Feedbro.png: screenshot (see below)
- atom.html: this could be integrated in our site
- atom.xml: this would be the new atom feed format
The screenshot demonstrates how the browser addon "Feedbro" works. The menu "Find Feeds in Current Tab" finds the two links embedded in the page <head>:
<link rel='alternate' title='FLTK RSS feed' href='index.rss' type='application/rss+xml' />
<link rel="alternate" title="FLTK Atom feed" href="atom.xml" type="application/atom+xml" />
The first link already exists, the second link is the new one.
There's no need to click on the link itself, you can mark any of the feeds, click on "Subscribe", and Feedbro watches the feed(s) for you. The menu "Open Feed Reader" lets you manage the feed messages and actually read them.
Note that "Feedbro" is only an example I installed after Firefox did not longer work with the RSS feed (as we know now, since 64.0). We can assume that users may install other addons or plugins if they're interested.
I think this is an option we could pursue by writing both the RSS and the Atom feed (xml) files to support maybe most of the browsers / plugins.
-----------------------
Note: I *temporarily* uploaded both files (atom.html and atom.xml) to the FLTK site so we can experiment with the demo contents:
https://www.fltk.org/atom.html
This link will only work for a limited time. See the uploaded files in the "Trouble Report Files" section of this STR for persistent example files. | |
| |
| #45 | AlbrechtS
05:54 May 16, 2021 |
| Wikipedia about "Atom (Web standard)":
https://en.wikipedia.org/wiki/Atom_%28Web_standard%29 | |
| |
| #46 | AlbrechtS
10:31 May 16, 2021 |
| BTW, some interesting, FLTK related Atom feeds:
Recent Commits to fltk:master
https://github.com/fltk/fltk/commits/master.atom
Recent Commits to fltk:branch-1.3:
https://github.com/fltk/fltk/commits/branch-1.3.atom
Given these examples we could name our news feed e.g. 'fltk-news.atom' or just 'fltk.atom'. | |
| |
| #47 | AlbrechtS
12:55 May 16, 2021 |
| Update: I replaced the previously uploaded files (atom.html and atom.xml) with two new files (news.html and news.atom) on the FLTK website. (Files uploaded to this STR not changed.)
Test URL:
https://www.fltk.org/news.html
The modified atom feed can be accessed here:
https://www.fltk.org/news.atom
The file 'news.atom' is hand-made but simplified as much as quickly possible. HTML code in news contents has been escaped as necessary. This is meant as a proof of concept.
I'm not sure if we need a unique id (uuid) per entry, but if, we could add it to the article database. OTOH I think we could also create one that contains the article number and makes the id unique (if we need one at all).
This is work in progress, but it works so far with my firefox addons 'Feedbro' and 'Livemarks' as suggested by Greg. | |
