@ManoloFLTK Great, thank you very much for taking care of this.

Do you see remaining issues?

Yes, one minor issue: we should not check the current desktop environment variable at all (Link: it is done to check for KDE). This check can be removed entirely.

Rationale (not only for my environment, but let's use this as an example): I have both KDE and Gnome installed on my system, and both kdialog and zenity are available. If I (or any other user, of course) enable OPTION_FNFC_USES_KDIALOG then that's what I want to use. I'm currently using the Gnome desktop and I can't use kdialog although I set the option because it's blocked due to XDG_CURRENT_DESKTOP=GNOME. That's surprising for the user, unexpected, and not documented. Rather than changing the docs we should remove the XDG_CURRENT_DESKTOP check.

The documentation of the option states:

Meaningful for the Wayland/X11 platform /and the KDE-Plasma desktop/ only.

We should remove the part "and the KDE-Plasma desktop". As you can see in my example there's nothing wrong with using kdialog under the Gnome desktop (tested, works). We should allow this.

If you agree, please remove the check and feel free to close the issue.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <fltk/fltk/issues/899/2069996828@github.com>