FLTK logo

Re: [fltk/fltk] CMake: Use imported targets for PkgConfig packages (PR #954)

FLTK matrix user chat room
(using Element browser app)   FLTK gitter user chat room   GitHub FLTK Project   FLTK News RSS Feed  
  FLTK Apps      FLTK Library      Forums      Links     Login 
 All Forums  |  Back to fltk.issues  ]
 
Previous Message ]New Message | Reply ]Next Message ]

Re: [fltk/fltk] CMake: Use imported targets for PkgConfig packages (PR #954) Albrecht Schlosser 14:26 Apr 14  
 

No worries, I thought your response was incredibly fast.

Thanks.

I noticed that there could be missing include directories using just _LDFLAGS, but testing on your latest commit doesn't have any issues with missing include directories for me on Linux via Conan. The Conan package doesn't use or ship the fltk-config script, which is probably why this wouldn't turn up any errors for me.

If Conan doesn't use the fltk-config script it shouldn't be affected by my commit which targets only the generation of this script. We didn't get any reports about missing include dirs but OTOH I know (and you wrote) that using the CMake target in a pure CMake build includes both the linker flags and the include directories. So what I wanted to say: If there's a need to use an additional include directory because pkg-config "finds" packages in non-standard dirs, then this works in a pure CMake build (like Conan seems to be) - however we are ignoring these potential include directories in fltk-config because I only picked the linker flags so far. There would be a risk that fltk-config --compile wouldn't work in such a scenario, but since I'm aware of this I can investigate this separately.


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <fltk/fltk/pull/954/c2054188899@github.com>

Direct Link to Message ]
 
     
Previous Message ]New Message | Reply ]Next Message ]
 
 

Comments are owned by the poster. All other content is copyright 1998-2024 by Bill Spitzak and others. This project is hosted by The FLTK Team. Please report site problems to 'erco@seriss.com'.