|
|
@jwillikers Sorry for the delay, I was distracted by other stuff. Finally I decided to merge your PR as-is and to push another commit after that. The reason was that some variables used to generate the fltk-config script were updated erroneously in your PR but I changed a lot more to "revert" this and to refactor and document the usage of these variables in commit b4cf1a9.
I'm pretty sure that our two commits together do what you intended and that the generation of fltk-config was improved by these two commits. There's a gray zone though which I'm not sure about: if it was necessary to add some include directories to the generated fltk-config script, then this has not been done yet because we can't add CMake targets to a shell script. The effect is that the correct libraries were added but there may be missing include directories. This needs investigation but I'm leaving this open for now.
That said, thanks for your support to improve the FLTK build system.
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: <fltk/fltk/pull/954/c2054128369@github.com>
[ Direct Link to Message ] | |
|
| |