This carries include directories and the required link flags. Several libraries brought in through pkg_check_modules aren't linked correctly using the _LDFLAGS variables. Instead, they link the libraries directly with -l. This is problematic because it doesn't properly pull in the actual directory of the library being linked when it is not in a system library directory. Likewise, the necessary include directories for several of these targets aren't properly set either. Linking against the imported targets automatically pulls in the necessary include directories.

This issue arose trying to build with Wayland support using Conan packages for the Wayland libraries. They provide the necessary pkg-config files, but since the libraries and includes are in non-standard locations, Wayland support can't be built.

You can view, comment on, or merge this pull request online at:

  https://github.com/fltk/fltk/pull/954

Commit Summary

• 4c9b766 CMake: Use imported targets for PkgConfig packages

File Changes

(3 files)

• M CMake/options.cmake (35)
• M CMake/variables.cmake (4)
• M src/CMakeLists.txt (16)

Patch Links:

• https://github.com/fltk/fltk/pull/954.patch
• https://github.com/fltk/fltk/pull/954.diff

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <fltk/fltk/pull/954@github.com>