FLTK logo

[fltk/fltk] Fix roundf() and nsvg__roundf() usage in nanosvg (Issue #943)

FLTK matrix user chat room
(using Element browser app)   FLTK gitter user chat room   GitHub FLTK Project   FLTK News RSS Feed  
  FLTK Apps      FLTK Library      Forums      Links     Login 
 All Forums  |  Back to fltk.issues  ]
 
Previous Message ]New Message | Reply ]Next Message ]

[fltk/fltk] Fix roundf() and nsvg__roundf() usage in nanosvg (Issue #943) Albrecht Schlosser 12:58 Mar 22  
 

This is a reminder for myself. No need for other devs to resolve this issue but patches (or even upstream PR's with a note here) would be appreciated.

I'm not going to work on this yet (the problem in FLTK [1] has been worked around) but when I do I'll add the label "active". Other devs or users working on this issue: please drop a note here to avoid duplicate work.

As discussed in #937 there's an inconsistency in nanosvg regarding its usage of roundf() and nsvg__roundf() in both supplied header files. For details please see this #937 (comment) and the following comments. Thanks to @wcout for pointing this out.

The goal is to patch the FLTK fork of nanosvg, open an upstream PR, and finally - once the PR is accepted - merge this in FLTK's fork and update the bundled nanosvg library.


[1] The problem with the usage of roundf() in nanosvg is that it's not provided by some old compilers, see linked issue comments.


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <fltk/fltk/issues/943@github.com>

Direct Link to Message ]
 
     
Previous Message ]New Message | Reply ]Next Message ]
 
 

Comments are owned by the poster. All other content is copyright 1998-2024 by Bill Spitzak and others. This project is hosted by The FLTK Team. Please report site problems to 'erco@seriss.com'.