Reproducing the crash on Mac in 1.3

The crash can easily be reproduced in 1.3 using the mandelbrot demo by simply commenting out the two if statements which perform the clamping of x2 and y2:

https://github.com/fltk/fltk/assets/5231310/29b2d485-27a3-4529-922f-97986195fe5f

The crash does not happen in 1.4:

https://github.com/fltk/fltk/assets/5231310/b3882df7-04c4-417b-b668-7f885adc4e8d

However, you can see in that video that 1.4 on Mac has a weird smearing issue (different from the smearing issue I noticed in 1.3 on Mac):

Of course, the smearing outside the mandelbrot drawing area is pretty much expected and not a real problem. But notice all the seemingly random smearing inside the mandelbrot drawing area.

You said:

If your program uses coordinates beyond the window borders then this could be called a programming error but I agree that FLTK should not crash.

I would disagree that it could be described as a programming error.
I think the aesthetic of an overlay rect with 3 visible edges and 1 offscreen edge (as opposed to all visible, clamped edges) should be completely valid.
Additionally, in my own application's case (not mandelbrot), the call to fl_overlay_rect() is inside the draw() of a Fl_Group, and the group is a child of a Fl_Scroll, so the group shouldn't be too concerned if certain parts of itself are visible or not, since most of the group is usually scrolled way off screen and not within the presently-visible region of the Fl_Scroll.
Obviously we're in agreement that FLTK shouldn't crash, so no issue, just adding my 2 cents.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <fltk/fltk/issues/735/1585843464@github.com>