I'm impressed! I read the code and docs, all looks very good. However, the macros are - as you wrote in fltk.coredev - "unreadable". Do I need to fully understand them? Probably not at this time.

Some first thoughts, I'd like to test it to get a feeling for the new features. This is not yet a review:

1. (Why) do we need this do { ... } while (0); construct? Wouldn't simple curly braces { ... }; be sufficient? The do seems to imply some kind of loop - until you see while (0);. Confusing.
2. The "user_data auto-free" feature looks good by itself. Would it be possible to strip this off of this PR and commit it separately before the PR gets merged ? Note: if you commit the auto-free feature to master, a following rebase of your branch should "just work" (maybe with minimal fixes).
3. Nothing more for now, except the usual typos ;-) ... which I may report in another proof reading. Don't worry yourself.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <fltk/fltk/pull/729/c1537480848@github.com>