FLTK logo

Re: [fltk/fltk] Fluid: enhancement for widget_class for extra option: reposition-and-rescale (PR #481)

FLTK matrix user chat room
(using Element browser app)   FLTK gitter user chat room   GitHub FLTK Project   FLTK News RSS Feed  
  FLTK Apps      FLTK Library      Forums      Links     Login 
 All Forums  |  Back to fltk.issues  ]
 
Previous Message ]New Message | Reply ]Next Message ]

Re: [fltk/fltk] Fluid: enhancement for widget_class for extra option: reposition-and-rescale (PR #481) Albrecht Schlosser Aug 15, 2022  
 

@etorth Yes, thank you for this additional scenario which is a good point. It could also be useful for other widgets (groups) that are not just one row or column and can thus not use Fl_Flex. In the near future Fl_Grid will give us even more options.

That said, I'm not going to merge your request now because I'm not sure about all the code changes. Our fluid specialist @MatthiasWM may hopefully chime in and decide whether your PR should be merged or modified in any way. Thank you for all your work on this and for the helpful discussion.

Summary, from my point of view:

  • the proposal could be a useful feature for some cases.
  • including math.h and using round() should be avoided if possible
  • I did not test the actual patch/PR, this needs to be done
  • hence I don't know if there would be any side effects

@MatthiasWM Matthias, what do you think, should we merge it?


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <fltk/fltk/pull/481/c1214942112@github.com>

Direct Link to Message ]
 
     
Previous Message ]New Message | Reply ]Next Message ]
 
 

Comments are owned by the poster. All other content is copyright 1998-2024 by Bill Spitzak and others. This project is hosted by The FLTK Team. Please report site problems to 'erco@seriss.com'.