| |
| |
On Wednesday, November 23, 2022 at 8:41:13 AM UTC-8 may64…@gmail.com wrote:
The interface is really nice.
A nit I had while trying things out. Things didn't work initially since the headers lacked include guards and lacked includes of the other relevant headers (Fl_Helper, Fl_Exception ...etc). Looking at the makefile, the include guards and proper includes seem to be added there: ``` cat $(INCLUDES) >> include/FL/Fl_Flow.H
``` I prefer for header-only libs that they be directly usable without having to go through a make step. Originally include/FL/Fl_Flow.H was checked in, but that file is generated from the .h files in src/Fl_Flow , as you point out.There’s also a Fl_Flow.h (note the capitalization) in that folder. This caused me lots of confusion while I was developing this feature. I kept making changes in Fl_Flow.H only to have them disappear the next time I ran make. IMHO, generated files should never be checked in, but ultimately this is up to Karsten, of course. I was somewhat surprised that he accepted that change without comment.
You received this message because you are subscribed to the Google Groups "fltk.general" group.
To unsubscribe from this group and stop receiving emails from it, send an email to fltkgeneral+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/fltkgeneral/177f62c9-4b43-44e2-ad2a-3f336a30636en%40googlegroups.com.
[ Direct Link to Message ] | |
|
| |
