| |
| |
On 4/22/20 12:54 AM imm wrote:
On Tue, 21 Apr 2020, 23:48 sam taylor, wrote:
Dear all,
Is something going wrong?
In Fltk 1.3.5 source code I noticed the occurance of a string "$Id$"
at the top and bottom of files that I looked at.
I also noticed that same string in files from the latest snapshot
i.e. fltk-1.4.x-20200417-75f47a76.tar.gz
However when I looked at old copies of FLTK I noticed that the
"$Id$" strings had been 'expanded' for example:
Was this an intended change or is something going wrong with the
creation of the 'tar.gz' files
Nah, that's just what happens when you switch from svn to git and
haven't got around to fixing the old tags yet...
Yep, we didn't even decide what to do with them. Are they maybe of any
use later?
There's not really an equivalent in git to the old cvs-style tags that
svn has, I think.
Not directly in git, but there's an option called filters: "smudge
filter" and "clean filter" (IIRC), where the smudge filter can be used
to expand the string when checking out and the clean filter does the
opposite when checking a file in.
There is at least one fundamental issue: these filters can only be
defined in the local repository, i.e. if we wanted to use them globally
all users (or at least all devs) would have to use them *identically* in
their own repos. Although the expansion wouldn't matter much, the "clean
filter" would need to work 100% accurately - otherwise we'd get the
expanded strings into the repository.
I also believe that they might show up in `git diff` but I'm not sure
and I didn't test it. At least they would be visible in diffs with other
tools (as did the old svn id's) besides real diffs.
We could, however, try to use a "smudge filter" when checking out the
sources for the official tar balls and snapshots. But even if this
worked fine we'd have all these different id tags when diff'ing sources
from older and newer snapshots or releases.
Seeing all the downsides I'm not sure it's worth it.
I know this is not really the place to discuss it, but anyway: I could
imagine to remove the $Id$ string at the top of the file and expand it
at the end of the file to just something like "End of <filename>"
because that was one of the reasons in the original concept: show that
the file is complete. OTOH, this might have been an issue in times when
files were transferred with insecure protocols via modems and no longer
today.
What do other devs and users think? Should we remove the $Id$ tags
completely, or anything else?
--
You received this message because you are subscribed to the Google Groups "fltk.general" group.
To unsubscribe from this group and stop receiving emails from it, send an email to fltkgeneral+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/fltkgeneral/29368fe3-e213-814b-1325-6c4f7cd10ddb%40online.de.
[ Direct Link to Message ] | |
|
| |
