|
|
Thanks for the report and the patch.
- Bug confirmed: test/pixmap_browser crashes when opening the provided GIF image whereas several other tools can open it
- Fix confirmed: the provided patch fixes this issue.
Before I commit this change I'd like to know more about the bug and the fix. Since you (@wcout) found the fix I'm sure you know much better what's going on than me (right now). Before I dig deeper into the code (this decoding algorithm looks pretty complicated), can you explain in a few more words why your fix is the correct one and - maybe even more important - how we can verify that it doesn't break other cases (w/o just testing lots of images)?
The GIF doc says the application should continue to read 12 Bit Codes ...
Can you give a pointer to the docs, i.e. where do the docs say this? Is this an issue of the "Deferred Clear Code" mentioned in the beginning of these GIF docs?
Thanks in advance!
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.
[ Direct Link to Message ] | |
|
| |