On 3/12/24 20:50 Greg Ercolano wrote:

On 3/12/24 06:28, 'Albrecht Schlosser' via fltk.coredev wrote:

should the methods Fl_Terminal::selection_text_len() and
Fl_Terminal::selection_text() be public rather than protected?
Currently they are protected. Was this intentional?

    While intentional, I can see making it public, if for no other
purpose to be consistent
    with the other widgets that allow access to selections publicly.

Yep, sounds good.

    My thinking was that manipulation of this kind of thing would be
primarily in the
    context of a derived class (such as implementing a popup menu to
provide Copy/Paste),
    and therefore protected. Also, I would think someone doing this
might also want access
    to the color/attribute information, which starts getting into the
internals, as there's no
    "standard" way to access color information that I'd think would be
safe to be public.

I agree, you can always want to access more, but having access to the
(selection) text seems sensible.

Anyway, I'll change it to be public, as these methods work with simple
text,
    devoid of color/attribute information. Commit forthcoming.

Thanks.

--
You received this message because you are subscribed to the Google Groups "fltk.coredev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to fltkcoredev+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/fltkcoredev/67dc78c6-fb5e-449c-a9af-711e45fc2ab3%40aljus.de.