|
|
Running locally on my machine:
D:\dev\fl\glt2\fltk\src\drivers\WinAPI\Fl_WinAPI_Gl_Window_Driver.cxx(157) : error C4716: 'Fl_WinAPI_Gl_Window_Driver::create_gl_context': must return a value NMAKE : fatal error U1077: 'C:\PROGRA~1\MICROS~4\2022\COMMUN~1\VC\Tools\MSVC\1432~1.313\bin\Hostx64\x64\cl.exe' : return code '0x2' Stop. NMAKE : fatal error U1077: '"C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.32.31326\bin\HostX64\x64\nmake.exe"' : return code '0x2' Stop. NMAKE : fatal error U1077: '"C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.32.31326\bin\HostX64\x64\nmake.exe"' : return code '0x2' Stop.
Adding a return to create_gl_context fixes the issue:
diff --git a/src/drivers/WinAPI/Fl_WinAPI_Gl_Window_Driver.cxx b/src/drivers/WinAPI/Fl_WinAPI_Gl_Window_Driver.cxx index bf5f791..50af220 100644 --- a/src/drivers/WinAPI/Fl_WinAPI_Gl_Window_Driver.cxx +++ b/src/drivers/WinAPI/Fl_WinAPI_Gl_Window_Driver.cxx @@ -153,7 +153,7 @@ GLContext Fl_WinAPI_Gl_Window_Driver::do_create_gl_context(Fl_Window* window,
GLContext Fl_WinAPI_Gl_Window_Driver::create_gl_context(Fl_Window* window, const Fl_Gl_Choice* g) { - do_create_gl_context(window, g, 0); + return do_create_gl_context(window, g, 0); }
void Fl_WinAPI_Gl_Window_Driver::set_gl_context(Fl_Window* w, GLContext context) {
On Sunday, October 2, 2022 at 6:22:24 PM UTC+3 Mo_Al_ wrote:
Looking at the logs:
229 D:\a\fltk\fltk\src\drivers\WinAPI\Fl_WinAPI_Gl_Window_Driver.cxx(157): error C4716: 'Fl_WinAPI_Gl_Window_Driver::create_gl_context': must return a value [D:\a\fltk\fltk\build\src\fltk_gl.vcxproj]
On Sunday, October 2, 2022 at 5:23:01 PM UTC+3 Manolo wrote:
I don't understand why did the last Windows build (commit 1fc23f8) by github CI fail.
The cmake Windows build with the same source code works here in my hands. The log of the CI build gives no explanatory error message, and goes all the way to
the link of the last test executable, wizard.
Is it because the available time for the FLTK project to perform CI builds has been reached ?
Here are the ends of the logs of the last successful build and the failing build :
===================================
end of last successful windows build (commit abc6709) :
unittest_viewport.cxx unittest_scrollbarsize.cxx unittest_schemes.cxx unittest_simple_terminal.cxx Generating Code... unittests.vcxproj -> D:\a\fltk\fltk\build\bin\test\Release\unittests.exe Building Custom Rule D:/a/fltk/fltk/test/CMakeLists.txt utf8.cxx utf8.vcxproj -> D:\a\fltk\fltk\build\bin\test\Release\utf8.exe Generating valuators.cxx, valuators.h Building Custom Rule D:/a/fltk/fltk/test/CMakeLists.txt valuators.cxx valuators.vcxproj -> D:\a\fltk\fltk\build\bin\test\Release\valuators.exe Building Custom Rule D:/a/fltk/fltk/test/CMakeLists.txt windowfocus.cxx windowfocus.vcxproj -> D:\a\fltk\fltk\build\bin\test\Release\windowfocus.exe Building Custom Rule D:/a/fltk/fltk/test/CMakeLists.txt wizard.cxx wizard.vcxproj -> D:\a\fltk\fltk\build\bin\test\Release\wizard.exe Building Custom Rule D:/a/fltk/fltk/CMakeLists.txt
=============== end of unsuccessful windows build (commit 1fc23f8)
Generating tree.cxx, tree.h Building Custom Rule D:/a/fltk/fltk/test/CMakeLists.txt tree.cxx tree.vcxproj -> D:\a\fltk\fltk\build\bin\test\Release\tree.exe Building Custom Rule D:/a/fltk/fltk/test/CMakeLists.txt twowin.cxx twowin.vcxproj -> D:\a\fltk\fltk\build\bin\test\Release\twowin.exe Building Custom Rule D:/a/fltk/fltk/test/CMakeLists.txt utf8.cxx utf8.vcxproj -> D:\a\fltk\fltk\build\bin\test\Release\utf8.exe Generating valuators.cxx, valuators.h Building Custom Rule D:/a/fltk/fltk/test/CMakeLists.txt valuators.cxx valuators.vcxproj -> D:\a\fltk\fltk\build\bin\test\Release\valuators.exe Building Custom Rule D:/a/fltk/fltk/test/CMakeLists.txt windowfocus.cxx windowfocus.vcxproj -> D:\a\fltk\fltk\build\bin\test\Release\windowfocus.exe Building Custom Rule D:/a/fltk/fltk/test/CMakeLists.txt wizard.cxx wizard.vcxproj -> D:\a\fltk\fltk\build\bin\test\Release\wizard.exe Error: Process completed with exit code 1. ===================
--
You received this message because you are subscribed to the Google Groups "fltk.coredev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to fltkcoredev+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/fltkcoredev/ba506a92-b8f7-4ea7-ba18-90e9a4475477n%40googlegroups.com.
[ Direct Link to Message ] | |
|
| |