FLTK logo

Re: [fltk.coredev] Re: macOS make install fails when run with ExternalProject_Add()

FLTK matrix user chat room
(using Element browser app)   FLTK gitter user chat room   GitHub FLTK Project   FLTK News RSS Feed  
  FLTK Apps      FLTK Library      Forums      Links     Login 
 All Forums  |  Back to fltk.coredev  ]
 
Previous Message ]New Message | Reply ]Next Message ]

Re: Re: macOS make install fails when run with ExternalProject_Add() Albrecht Schlosser Aug 14, 2022  
 
On 8/14/22 07:00 Rob McDonald wrote:
I have used the same ExternalProject_Add() setup with many versions both 1.3 and 1.4.

Rather than fetch from fltk's git, I use a *.zip file included in my project git repository.  I name that file after the SHA in the FLTK repo.  Consequently, this code currently references



OK, thanks for all input, @Rob and @Gonzalo.

I believe the culprit is:

commit 14ae784f7fe08b8c051e2109a8325b671a8e1b23
Author: Matthias Melcher <...>
Date:   Sat Jan 1 13:53:21 2022 +0100

    Installing Fluid correctly on macOS


The commit Rob is using is older than the one above:
commit 47ba6632b1be5ab7f28726735fc7789916191ca7
Author: ManoloFLTK <...>
Date:   Thu May 27 08:49:12 2021 +0200

     macOS: Avoid premature FL_RELEASE event at start of drag-n-drop operation.
    
Rob, could you please test with 14ae784f7fe0 or with current master? Thanks in advance.


Gonzalo, since you are using the current version, can you please test with 14ae784f7fe08 and with the one before that one:

$ git log -1 14ae784f7fe08b8^
commit eeb3e92eb29c4fdbcdc0b0276753c1d32210a8e5
Author: ManoloFLTK <...>
Date:   Wed Dec 29 17:18:12 2021 +0100

     Fix fullscreen window level corner cases on macOS - cont'd

Before I try to fix this I'd appreciate if at least one of you could confirm that 14ae784f7fe08 is indeed the culprit. I will also try to reproduce the issue with Gonzalo's CMake script but this may take a while, please don't hold your breath. Gonzalo, thank you particularly for that as well.

That said, according to the code I saw it looks very much like the change Matt introduced ignores CMAKE_INSTALL_PREFIX which would be a bug. We need to find a way to implement the gist of Matt's change w/o ignoring CMAKE_INSTALL_PREFIX.

--
You received this message because you are subscribed to the Google Groups "fltk.coredev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to fltkcoredev+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/fltkcoredev/80eab6e8-0562-f275-4fb5-fd434a84cc10%40online.de.
Direct Link to Message ]
 
     
Previous Message ]New Message | Reply ]Next Message ]
 
 

Comments are owned by the poster. All other content is copyright 1998-2024 by Bill Spitzak and others. This project is hosted by The FLTK Team. Please report site problems to 'erco@seriss.com'.