| |
| |
On 3/22/22 20:11 imm wrote:
On Tue, 22 Mar 2022, 16:53
Albrecht Schlosser wrote:
Yes, please. It would be a great help if you could do this
(since you dived into the code already). TIA
This (renaming) and the replacement of the wrong code
above would be very much appreciated.
OK, I'll have a look, though won't be this
evening (currently watching a kids water polo match, now
they're allowed to play competitive matches again...)
Have fun!
The preferred approach is to make a clone on
GitHub, do the patch, then send (you?) a PR, I think?
Is that the way?
Well, you have write access, so you could commit and push to GitHub
(fltk/fltk) yourself.
However, if you prefer to make a PR so someone can review it, then
this is how it works:
1) fork on GitHub (fltk/fltk to your-account/fltk)
2) create a working branch on your fork on top of master
3) push your commit(s) to this branch
4) create a PR on GitHub
There's no one you send the PR to. You just create it directly on
GitHub (web interface).
You'll get instructions when you push to your branch (point 3 above)
for the first time.
In short commands:
1) fork on GitHub (user interface)
2) git clone <your-URL> <your-working-dir>
3) cd <your-working-dir>
4) git checkout master (this is the default anyway)
5) git branch working
6) git checkout working
7) git add, git commit, ...
8) git push <remote> working
9) create PR on GitHub or as instructed
Notes:
- In (2) <your-URL> is the likely
https://github.com/UserName/fltk.git
- In (2) and (3) <your-working-dir> would likely be 'fltk'
- I used the branch name 'working' (select a better one)
- In (7) the remote name defaults to 'origin' if you forked and
cloned as described above
- If you want to push to your fork with a 'https' URL you need to
create a "personal access token" (with "repo" permission) on your
GitHub account first (only once) and use your username with this
token as the password to authenticate. Store this token in a safe
place, you can't see it again (but you can create another one if you
lost it). Alternatively you can set up git/ssh access but that would
be OT here.
- When you do (8) on the commandline you'll get instructions how to
create the PR
- Since you have write access you can also finally "merge" the PR on
GitHub or let someone else (me?) do it.
Thanks
Albrecht
--
You received this message because you are subscribed to the Google Groups "fltk.coredev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to fltkcoredev+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/fltkcoredev/264e38b8-9765-7a02-3c82-f23a2abcbbc3%40online.de.
[ Direct Link to Message ] | |
|
| |
