FLTK logo

Re: [fltk.coredev] Fix issue #254: remove hardware overlay support (X11)

FLTK matrix user chat room
(using Element browser app)   FLTK gitter user chat room   GitHub FLTK Project   FLTK News RSS Feed  
  FLTK Apps      FLTK Library      Forums      Links     Login 
 All Forums  |  Back to fltk.coredev  ]
 
Previous Message ]New Message | Reply ]Next Message ]

Re: Fix issue #254: remove hardware overlay support (X11) Albrecht Schlosser Nov 26, 2021  
 
On 11/25/21 5:26 PM Manolo wrote:
I propose the series of modifications given in the attached patch
to fix for 1.4 issue #254: remove hardware overlay support.
This would remove one milestone item for Release 1.4

+1

The proposal leaves unchanged the support of HAVE_GL_OVERLAY
for the WIN32 platform.
Can someone give info about whether this is functional?
With Windows inside VirtualBox, there's no access to such feature.

I have no idea, but see Ian's post.

Any comment?

I propose to proceed with the X11 overlay stuff independent of the Windows HAVE_GL_OVERLAY question so we can close issue #254.

The Windows stuff should be separated anyway in another issue / patch / PR.

One minor nitpick regarding the patch: the alignment in line 635 of the patch might need adjustment (not tested):

Line # ca. 233 of new src/drivers/Xlib/Fl_Xlib_Graphics_Driver_color.cxx:

-      numcolors = fl_visual->colormap_size;
+    numcolors = fl_visual->colormap_size;

(or similar, edited manually)

Other than that: great, please go ahead. Thanks.

--
You received this message because you are subscribed to the Google Groups "fltk.coredev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to fltkcoredev+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/fltkcoredev/6961fde1-507f-8231-c5ee-d8dd6265a170%40online.de.
Direct Link to Message ]
 
     
Previous Message ]New Message | Reply ]Next Message ]
 
 

Comments are owned by the poster. All other content is copyright 1998-2024 by Bill Spitzak and others. This project is hosted by The FLTK Team. Please report site problems to 'erco@seriss.com'.