Re: [fltk.coredev] Re: FLTK 1.3.6 Release Candidate 1 is now available for download and testing - Forums

I just cloned from github and checked out the 1.3 branch. With the renamed VERSION file, everything builds great on macOS

I tested the build on an M1 Mac as well. Looks great and the few apps I tried run really well.

There is a single change people can make on macOS to allow building a "universal" app. I added this one line in "cmake/Setup.cmake"

$ git diff
──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
modified: CMake/setup.cmake
──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
@ CMake/setup.cmake:25 @
set (EXECUTABLE_OUTPUT_PATH ${CMAKE_CURRENT_BINARY_DIR}/bin)
set (LIBRARY_OUTPUT_PATH ${CMAKE_CURRENT_BINARY_DIR}/lib)
set (ARCHIVE_OUTPUT_PATH ${CMAKE_CURRENT_BINARY_DIR}/lib)
set (CMAKE_OSX_ARCHITECTURES "arm64;x86_64")

# Search for modules in the FLTK source dir first
set (CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/CMake")

and after a rebuild, you can see the results are fat binaries:

$ file bin/fluid.app/Contents/MacOS/fluid
bin/fluid.app/Contents/MacOS/fluid: Mach-O universal binary with 2 architectures: [x86_64:Mach-O 64-bit executable x86_64] [arm64]
bin/fluid.app/Contents/MacOS/fluid (for architecture x86_64): Mach-O 64-bit executable x86_64
bin/fluid.app/Contents/MacOS/fluid (for architecture arm64): Mach-O 64-bit executable arm64

Bob Tolbert

On Thu, Apr 29, 2021 at 4:45 AM Albrecht Schlosser <AlbrechtS.fltk@online.de> wrote:

On 4/29/21 11:15 AM Manolo wrote:
>
>
> On Monday, April 26, 2021 at 10:16:26 PM UTC+2 Albrecht Schlosser wrote:
>
> The first release candidate for FLTK 1.3.6 is now available for
> download and testing.
> Please test and report bugs within 2 weeks (until May 10, 2021) if
> you find any issues with this release candidate.
>
>
> Many thanks to Albrecht for putting up this RC.

Welcome. Thanks for testing...

> Here are the tests I performed, all errorless:
> - standard configure build under macOS 11.2.3
> - configure --enable-x11 build under macOS 11
> - standard configure build under Windows XP

Did you notice the error report from Bob Tolbert about:

/Users/bob/build/fltk-1.3.6rc1/version:1:1: error:

...
expected unqualified-id
1.3.6
^

It seems clear to me that this is caused by our file named VERSION in
the FLTK root directory which I asked Bob to rename and build again.
This file is included by system headers which want to #include
<version>, a new C++ header.

I already committed a fix to Git on branch-1.3.

My question to you (and others): Do you have a macOS system with a case
/insensitive/ file system where you can test and see if the error
manifests? That's just for curiosity but it might help. I know that we
had a user report of the same issue on Windows (and I renamed the file
in 1.4.0).

Maybe the build needs to be run with --std=C++11 or C++14 or whatever to
trigger the error though.

A simple test should be to `git clone` the FLTK repo and run `make` in
the FLTK root dir.

--
You received this message because you are subscribed to the Google Groups "fltk.coredev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to fltkcoredev+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/fltkcoredev/bf76319e-b341-667d-53d5-e9d0b7e7281f%40online.de.