FLTK logo

Re: [fltk.coredev] RFC: Disable Visual Studio warning about

FLTK matrix user chat room
(using Element browser app)   FLTK gitter user chat room   GitHub FLTK Project   FLTK News RSS Feed  
  FLTK Apps      FLTK Library      Forums      Links     Login 
 All Forums  |  Back to fltk.coredev  ]
 
Previous Message ]New Message | Reply ]Next Message ]

Re: RFC: Disable Visual Studio warning about Manolo Feb 23, 2021  
 

On Tuesday, February 23, 2021 at 10:50:52 PM UTC+1 Albrecht Schlosser wrote: 
So after all I think both options (1: extra implementation file) and (2:
see patch) are fine and I'm undecided.

Votes, anybody?

Options 1 and 2 were  defined as follows :
> (1) Enable the warning (pragma) in Fl_SVG_Image.cxx just before we
> include the nanosvg headers and (maybe [1]) disable it afterwards.
>
> (2) Use a new file just for the nanosvg implementation (maybe
> fl_nanosvg.cxx?) and use the #pragma before the inclusion of nanosvg
> headers (no restore needed [1]).

Therefore I'm a little confused when I read
  "option[s] (1: extra implementation file) "

My vote would be for
"Enable the warning (pragma) in Fl_SVG_Image.cxx and disable it afterwards"
with the advantage of not introducing a new file with very little added value.

But, is it possible that some older versions of Visual Studio don't support
#pragma warning (push) / #pragma warning (pop)
In that case, option
"Use a new file just for the nanosvg implementation"
would be my choice.

--
You received this message because you are subscribed to the Google Groups "fltk.coredev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to fltkcoredev+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/fltkcoredev/2d79aa47-7c34-4bca-81e4-20db40514282n%40googlegroups.com.
Direct Link to Message ]
 
     
Previous Message ]New Message | Reply ]Next Message ]
 
 

Comments are owned by the poster. All other content is copyright 1998-2024 by Bill Spitzak and others. This project is hosted by The FLTK Team. Please report site problems to 'erco@seriss.com'.