Re: [fltk.coredev] RFC: Disable Visual Studio warning about - Forums

On Mon, 22 Feb 2021, 10:59 Manolo wrote:

There remain a few VisualStudio warnings coming from file nanosvg.h which
gets included by Fl_SVG_Image.cxx when building libfltk_images :

1>…\fltk\src\../nanosvg/nanosvg.h(1433,12): warning C4244: 'initialisation' : conversion of 'double' to 'float', possible data loss
1>…\fltk\src\../nanosvg/nanosvg.h(1441,12): warning C4244: 'initialisation' : conversion of 'double' to 'float', possible data loss
1>…\fltk\src\../nanosvg/nanosvg.h(1474,26): warning C4244: '=' : conversion of 'double' to 'float', possible data loss
1>…\fltk\src\../nanosvg/nanosvg.h(2517,29): warning C4244: '=' : conversion of 'double' to 'float', possible data loss
1>…\fltk\src\../nanosvg/nanosvg.h(2521,29): warning C4244: '=' : conversion of 'double' to 'float', possible data loss
1>…\fltk\src\../nanosvg/nanosvg.h(2525,30): warning C4244: '=' : conversion of 'double' to 'float', possible data loss
1>…\fltk\src\../nanosvg/nanosvg.h(2529,31): warning C4244: '=' : conversion of 'double' to 'float', possible data loss

What about adding in our own nanosvg branch an extra "pragma warning" to the 2 already present in nanosvg.h and obtain

#ifdef _MSC_VER
   #pragma warning (disable: 4996) // Switch off security warnings
    #pragma warning (disable: 4100) // Switch off unreferenced formal parameter warnings
    #pragma warning (disable: 4244) // Switch off implicit type conversion warnings <---- this would be added

Alternatively, would adding explicit casts work to silence the warning?

I think an explicit cast (if it works!) would be "better" than turning off the warning with the pragma. Maybe...

--
Ian
From my Fairphone FP3