| |
| |
On 2/17/21 3:30 PM, Greg Ercolano wrote:
On 2/17/21 2:56 PM, Bill Spitzak wrote:
It looks like fl_open and fl_fopen already exist
in fltk
Nice, looks like we inherited this from OksiD's utf8 port.
Well that should be easy to fix the warnings in fluid then..!
Actually, looks like the warning for open() is
only in the zlib project ('gzlib.c'),
and that use is already in a wrapper function called gz_open()
which /seems/
to handle wide chars conversion already.
So in that case just silencing the warning would help when
building that project.
Leaving warnings on for at least open() would be good so that if
any fltk dev
adds a call to open() in the library code, we'll get a warning
about it, and (eventually)
come to the conclusion to use fl_open() instead.
It's interesting to me there's no warning about our use of open()
in the Fl_WinAPI_System_Driver.cxx
code:
int Fl_WinAPI_System_Driver::open_ext(const char *fnam, int
binary, int oflags, int pmode) {
if (oflags == 0) oflags = _O_RDONLY;
oflags |= (binary ? _O_BINARY : _O_TEXT);
return open(fnam, oflags, pmode);
}
Which must mean we're somehow disabling warnings there.
Perhaps whatever that is just needs to be added to the zlib
project..?
--
You received this message because you are subscribed to the Google Groups "fltk.coredev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to fltkcoredev+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/fltkcoredev/db0c32cc-9dda-d784-226e-b64d3cd3c200%40seriss.com.
[ Direct Link to Message ] | |
|
| |
