FLTK logo

Re: [fltk/fltk] Read Access Violation in FL_Browser in x64 (Windows) (#197)

FLTK matrix user chat room
(using Element browser app)   FLTK gitter user chat room   GitHub FLTK Project   FLTK News RSS Feed  
  FLTK Apps      FLTK Library      Forums      Links     Login 
 All Forums  |  Back to fltk.issues  ]
 
Previous Message ]New Message | Reply ]Next Message ]

Re: [fltk/fltk] Read Access Violation in FL_Browser in x64 (Windows) (#197) Jeffrey Paranich Mar 03, 2021  
 

Thanks guys, I just recompiled everything from scratch and will see if the issue clears up; and report back.

It did dawn on me however; would it not be proper for the offending piece:

if (l->icon && (l->icon->h()+2)>hmax)

to be re-written as

if (l->icon->h()+2)>hmax && l->icon ) ?

I seem to recall most compilers will generate assembly from right to left, so technically it tries to check the icon height before testing if an icon exists. I noticed in other parts of FL_Browser, icon is always checked first before trying to access its elements.... just a thought.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Direct Link to Message ]
 
     
Previous Message ]New Message | Reply ]Next Message ]
 
 

Comments are owned by the poster. All other content is copyright 1998-2024 by Bill Spitzak and others. This project is hosted by The FLTK Team. Please report site problems to 'erco@seriss.com'.