Yes, that makes sense to me. I went with the #undef approach so that way we are using our own macro instead of using a macro from a system header. Although it's very likely that any min macro from a system header would function the same I don't see any reason to rely on that when we can be 100% sure we are using our own macro.

Windows.h also does that. I typically compile my Windows programs with -DNOMINMAX as a part of the CFLAGS.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.