FLTK logo

Re: [fltk/fltk] [FLTK 1.1] Fix min not defined compiler error. (#169)

FLTK matrix user chat room
(using Element browser app)   FLTK gitter user chat room   GitHub FLTK Project   FLTK News RSS Feed  
  FLTK Apps      FLTK Library      Forums      Links     Login 
 All Forums  |  Back to fltk.issues  ]
 
Previous Message ]New Message | Reply ]Next Message ]

Re: [fltk/fltk] [FLTK 1.1] Fix min not defined compiler error. (#169) ComputerNerd Dec 07, 2020  
 

I was also confused when I first got the error. I saw the min macro at the top of the file and in the fl_draw.cxx I didn't see anything that would cause it. It turns out that the Debian maintainers still seem to support FLTK 1.1 and have been writing patches for it. They moved the min macro down lower to resolve the error.

Here you can see their change and explanation:
https://salsa.debian.org/ucko/fltk1.1/-/blob/master/src/fl_draw.cxx
Quote from the page
src/fl_draw.cxx: Move the min macro's definition down, to ensure no headers have the opportunity to undefine it.

What I'll do is close this pull request and submit another one using the fix used by the Debian maintainers.

Also thank you for linking to the CMP document and for reviewing my patches. I will make sure any future changes comply with this.

For the compiler I'm using GCC 10.2.0. It seems like this issue started happening with GCC 6 according to the Debian maintainers.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Direct Link to Message ]
 
     
Previous Message ]New Message | Reply ]Next Message ]
 
 

Comments are owned by the poster. All other content is copyright 1998-2024 by Bill Spitzak and others. This project is hosted by The FLTK Team. Please report site problems to 'erco@seriss.com'.