DO NOT REPLY TO THIS MESSAGE. INSTEAD, POST ANY RESPONSES TO THE LINK BELOW.
Regarding my comment in src/Fl_Tiled_Image.cxx: no, the issue is not fixed
by your patch. The comment says "The latter can not be checked here..."
which refers to "... or widget", i.e. we don't have the widget size in this
The documentation above states: "Tiled images can be used as background
images for widgets and windows ..." and "If both \p W and \p H are 0 the
image is repeated as often as necessary to fill the entire window" (which
should, BTW, read "the entire window or widget, respectively).
So, the "trick" is, if both W and H are zero we always fill the entire
*window* and rely on clipping set correctly if only a particular *widget*
should be filled.
The problem arises only if a program calls Fl_Tiled_Image::draw() to fill a
widget and sets W and H to 0 (zero). Well, this is likely a pathological
case. Maybe we should disallow this, but as the documentation says, it's
legal right now.
This is just for clarification. If this is not an issue for you to be
discussed further, feel free to apply your patch and close this STR. TIA.
[ Direct Link to Message ]