Re: [MOD] STR #3532: timeout set by Fl::add_timeout elapses too early

GitHub FLTK Project   FLTK News RSS Feed  
  FLTK Apps      FLTK Library      Forums      Links     Login 
 All Forums  |  Back to fltk.bugs  ]
 
Previous Message ]New Message | Reply ]Next Message ]

Re: [MOD] STR #3532: timeout set by Fl::add_timeout elapses too early Albrecht Schlosser Jan 18, 2020 top right image
 
DO NOT REPLY TO THIS MESSAGE.  INSTEAD, POST ANY RESPONSES TO THE LINK BELOW.

[STR New]

Link: https://www.fltk.org/str.php?L3532
Version: 1.3.5


Thanks for the report. Indeed, this is true (Linux/Unix only) and has been
fixed in FLTK 1.4 (Git master, commit 35a3e7cc16f8) but not backported. See
also STR #3516 (which is about more than only this aspect).

The fix in FLTK 1.4 was to just clear 'missed_timeout_by' w/o saving and
restoring the value (as you propose) because it seems to be unnecessary. It
was a fault not to clear the missed_timeout_by value at all (except
overwriting it when serving the next timeout).

Do you have evidence that the value should be saved and restored, or was
this only kinda "defensive programming"?

I'm not sure if we should backport this to 1.3: after all it's not a
serious bug, it's only prio 3 (moderate).


Link: https://www.fltk.org/str.php?L3532
Version: 1.3.5


Direct Link to Message ]
 
bottom left image   bottom right image
Previous Message ]New Message | Reply ]Next Message ]
 
 

Comments are owned by the poster. All other content is copyright 1998-2021 by Bill Spitzak and others. This project is hosted by The FLTK Team. Please report site problems to 'erco@seriss.com'.