DO NOT REPLY TO THIS MESSAGE. INSTEAD, POST ANY RESPONSES TO THE LINK BELOW.
While we're at it (a little code review): I found some redundant and maybe
confusing code in Fl_Tree::handle() - as mentioned above, code as of today,
int ret = 0;
is defined early in handle() at line 227 (OK).
The statements at line 319 and 322 (ret = 1;) are redundant and should be
removed. This value is not used because there is 'return(1);' at line 324.
It's also possible to change this to 'return(ret);' but I think
'return(1);' is more explicit and to be preferred here.
That said, the statement at line 381 (after calling Fl_Group::handle())
if ( ! _root ) return(ret);
could also be written as:
if ( ! _root ) return(0);
because at this point in the code 'ret' is always zero.
The following statements use 'ret' correctly AFAICT.
Just my 2 ct.
[ Direct Link to Message ]