FLTK logo

[master] 3c6b34b - Fix a potential memory leak, see issue #457

FLTK matrix user chat room
(using Element browser app)   FLTK gitter user chat room   GitHub FLTK Project   FLTK News RSS Feed  
  FLTK Library      Forums      Links      Apps     Login 
 All Forums  |  Back to fltk.commit  ]
 
Previous Message ]Next Message ]

[master] 3c6b34b - Fix a potential memory leak, see issue #457 "Albrecht Schlosser" Jul 05, 2022  
 
commit 3c6b34bb70726d437204d78e2cc7a29db3cb9ceb
Author:     Albrecht Schlosser <albrechts.fltk@online.de>
AuthorDate: Tue Jul 5 18:48:46 2022 +0200
Commit:     Albrecht Schlosser <albrechts.fltk@online.de>
CommitDate: Tue Jul 5 18:49:15 2022 +0200

    Fix a potential memory leak, see issue #457

 src/Fl_Message.cxx | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git src/Fl_Message.cxx src/Fl_Message.cxx
index 06c2e76..7047fbf 100644
--- src/Fl_Message.cxx
+++ src/Fl_Message.cxx
@@ -485,12 +485,9 @@ const char *Fl_Message::input_innards(const char *fmt, va_list ap, const char *d
       input_buffer_[input_->size()] = '\0';
       return (input_buffer_);
 
-    } else { // new version: allocate string buffer
+    } else { // new version: return value() which will be copied
 
-      char *buf = (char *)malloc(size);
-      memcpy(buf, input_->value(), input_->size());
-      buf[input_->size()] = '\0';
-      return (buf);
+      return input_->value();
     }
 
   } else
Direct Link to Message ]
 
     
Previous Message ]Next Message ]
 
 

Comments are owned by the poster. All other content is copyright 1998-2025 by Bill Spitzak and others. This project is hosted by The FLTK Team. Please report site problems to 'erco@seriss.com'.