STR #66

FLTK Apps FLTK Library Forums Links Login

[ Return to Bugs & Features | Roadmap 1.1 | SVN ⇄ GIT ]

STR #66

Application:	FLTK Library
Status:	1 - Closed w/Resolution
Priority:	1 - Request for Enhancement, e.g. asking for a feature
Scope:	3 - Applies to all machines and operating systems
Subsystem:	Core Library
Summary:	Fl_Help_View doesn't handle A and &0x#40;
Version:	1.1.4rc1
Created By:	nickasil
Assigned To:	mike
Fix Version:	1.1.4
Update Notification:	Receive EMails Don't Receive EMails

Trouble Report Files:

#1	nickasil 06:24 Jun 03, 2003

Fl_Help_View.cxx.patch
1k

#2	nickasil 07:27 Jun 03, 2003

Fl_Help_View.cxx.patch
1k

Trouble Report Comments:

Name/Time/Date Text

#1	nickasil 06:18 Jun 03, 2003

Html numeric entities are not properly displayed. Here is the patch : --- Fl_Help_View.cxx.old Wed May 21 18:12:14 2003 +++ Fl_Help_View.cxx Tue Jun 03 15:11:00 2003 @@ -2760,8 +2760,12 @@ }; - if (isdigit(*p)) return atoi(p); - + if (*p == '#') { + if (*(p+1) == 'x' || *(p+1) == 'X') + return strtol(p+2, NULL, 16); + else + return atoi(p+1); + } for (i = (int)(sizeof(names) / sizeof(names[0])), nameptr = names; i > 0; i --, nameptr ++) if (strncmp(p, nameptr->name, nameptr->namelen) == 0) return nameptr->code;

#2	nickasil 07:29 Jun 03, 2003

the second patch fixes a major bug when the numerical entity is not terminated by a ;

#3	mike 16:29 Jun 11, 2003

Strictly speaking, Fl_Help_View is not a HTML widget and doesn't need to support everything from HTML. The patch looks simple enough, though, so we'll probably apply it for 1.1.4. Thanks for the patch!

#4	mike 18:20 Jun 11, 2003

Applied to CVS.

[ Return to Bugs & Features ]