| [ Return to Bugs & Features | SVN ⇄ GIT ]
STR #3429
Application: | FLTK Library |
Status: | 1 - Closed w/Resolution |
Priority: | 2 - Low, e.g. a documentation error or undocumented side-effect |
Scope: | 3 - Applies to all machines and operating systems |
Subsystem: | Core Library |
Summary: | Fl_Help_Dialog::load() should return int indicating success/failure |
Version: | 1.4-current |
Created By: | greg.ercolano |
Assigned To: | matt |
Fix Version: | 1.4.0 |
Fix Commit: | 0698e16a6b154f227dcb4ab135b273af1fa0f5f9 |
Update Notification: | |
Trouble Report Files:
Trouble Report Comments:
|
#1 | greg.ercolano 12:57 Nov 04, 2017 |
| Fl_Help_Dialog::load() is a wrapper method around Fl_Help_View::load().
The latter returns an int indicating success (0) or failure (-1), but the former does not pass that return value to the caller (it should).
Attaching a patch suggestion to solve, including doxygen modifications. If there are ABI issues changing the return type from void -> int, it shouldn't be a problem for 1.4.0.
This fix also helps a patch suggestion in STR #3428 for the test/help_dialog application.
PS. Patch includes a separate omission in the .fl file; someone added #include <FL/Fl_Shared_Image.H> to the .cxx file but not the .fl. To keep them in sync, added the omission to the .fl here. | |
|
#2 | matt 16:11 Feb 01, 2019 |
| Fixed in Git repository. | |
[ Return to Bugs & Features ]
|
| |