| | [ Return to Bugs & Features | SVN ⇄ GIT ]
STR #3334
| Application: | FLTK Library |
|---|
| Status: | 1 - Closed w/Resolution |
|---|
| Priority: | 2 - Low, e.g. a documentation error or undocumented side-effect |
|---|
| Scope: | 3 - Applies to all machines and operating systems |
|---|
| Subsystem: | Core Library |
|---|
| Summary: | Minor bug fixes to Fl_Tabs. |
|---|
| Version: | 1.4-current |
|---|
| Created By: | Teklad |
|---|
| Assigned To: | matt |
|---|
| Fix Version: | 1.4.0 |
|---|
| Fix Commit: | 8826dca1066361b474139bcc5aeed2e3a5246ed0 |
|---|
| Update Notification: | |
|---|
Trouble Report Files:
Trouble Report Comments:
| |
| #1 | Teklad
02:27 Sep 26, 2016 |
| So I noticed a couple of drawing issues related to Fl_Tabs, especially when removing tabs or adding a lot of tabs.
This patch addresses those without touching the API itself. The main issue was redraw() refused to work on an empty tab widget, and when removing tabs, the tab area didn't always redraw correctly.
The only other change is related to how tabs are packed, and the only reason this was changed is because the tab widget would become unusable with a lot of tabs.
I'm attaching a test program showing the modified behavior along with this patch. | |
| |
| #2 | AlbrechtS
23:20 Aug 06, 2018 |
| I moved this STR to 1.4-current because FLTK 1.3 development is closed.
Please see attached rewritten patch drawfixes_1.4.patch for updates necessary to move the patch. The patched file compiles, but I didn't test anything.
Notes: Tab alignment is now configurable - I commented some of the patched statements out and marked them with "// STR #3334" because these statements would no longer fit.
I left out an initialization "int i [ = 0];" because i is initialized later anyway. | |
| |
| #3 | AlbrechtS
23:24 Aug 06, 2018 |
| This does NOT mean that the patch would be acceptable as-is; it's just for evaluation. I'm not sure if we want floating point calculations in tabs adjustment (related to drawing) because of performance. But that's just something that should be considered.
There are other Fl_Tabs improvements that may render this request obsolete if (when) implemented.
@OP (Teklad): please feel free to update the patch and post a new one for FLTK 1.4 (remove or update the statements commented-out by me) or to request to close this STR. | |
| |
| #4 | matt
15:23 Jan 04, 2023 |
| GitHub PR #628 should fix all drawing issues when adding and removing tabs | |
| |
| #5 | matt
05:15 Jan 05, 2023 |
| Fixed in Git repository. | |
[ Return to Bugs & Features ]
|
| |
