FLTK logo

STR #3306

FLTK matrix user chat room
(using Element browser app)   FLTK gitter user chat room   GitHub FLTK Project   FLTK News RSS Feed  
  FLTK Apps      FLTK Library      Forums      Links     Login 
 Home  |  Articles & FAQs  |  Bugs & Features  |  Documentation  |  Download  |  Screenshots  ]
 

Return to Bugs & Features | Roadmap 1.3 | SVN ⇄ GIT ]

STR #3306

Application:FLTK Library
Status:1 - Closed w/Resolution
Priority:3 - Moderate, e.g. unable to compile the software
Scope:3 - Applies to all machines and operating systems
Subsystem:Core Library
Summary:Fl_Text_Editor::bound_key_function() should all be const
Version:1.3-current
Created By:greg.ercolano
Assigned To:greg.ercolano
Fix Version:1.3.4 (SVN: v11805)
Update Notification:

Receive EMails Don't Receive EMails

Trouble Report Files:


Name/Time/Date Filename/Size  
 
#1 greg.ercolano
16:58 May 20, 2016
test.php
0k
 
 
#2 greg.ercolano
15:53 Jul 13, 2016
bound_key_function_const.patch
1k
 
     

Trouble Report Comments:


Name/Time/Date Text  
 
#1 greg.ercolano
09:28 May 18, 2016
The bound_key_function() methods cannot currently be called by a const method because they're not const.

This would break ABI, so suggesting ABI guards for the short term.
 
 
#2 greg.ercolano
16:58 May 20, 2016
(Posting an unrelated test.php -- please ignore)  
 
#3 greg.ercolano
15:53 Jul 13, 2016
Attaching patch suggestion.  
 
#4 greg.ercolano
16:24 Jul 13, 2016
Fixed in Subversion repository.

Assigning to myself, committed as 11805, closed.
No brainer this method should be made const.

Useful for solving related STR#3305; bound_key_function() being non-const
prevents the new "tab_nav()" method from being added as const, since it
uses bound_key_function() to operate.

If it somehow causes trouble, reopen, or comment in fltk.coredev.
 
 
#5 greg.ercolano
13:21 Jul 19, 2016
Also applied to the 1.3-porting branch as r11819.  
     

Return to Bugs & Features ]

 
 

Comments are owned by the poster. All other content is copyright 1998-2024 by Bill Spitzak and others. This project is hosted by The FLTK Team. Please report site problems to 'erco@seriss.com'.