FLTK logo

STR #3302

FLTK matrix user chat room
(using Element browser app)   FLTK gitter user chat room   GitHub FLTK Project   FLTK News RSS Feed  
  FLTK Apps      FLTK Library      Forums      Links     Login 
 Home  |  Articles & FAQs  |  Bugs & Features  |  Documentation  |  Download  |  Screenshots  ]
 

Return to Bugs & Features | Roadmap 1.3 | SVN ⇄ GIT ]

STR #3302

Application:FLTK Library
Status:1 - Closed w/Resolution
Priority:2 - Low, e.g. a documentation error or undocumented side-effect
Scope:2 - Specific to an operating system
Subsystem:Core Library
Summary:gcc 3.5.1 warning in Fl_Table.cxx
Version:1.3-current
Created By:chris
Assigned To:AlbrechtS
Fix Version:1.3.4 (SVN: v11849)
Update Notification:

Receive EMails Don't Receive EMails

Trouble Report Files:

No files


Trouble Report Comments:


Name/Time/Date Text  
 
#1 chris
02:17 Apr 14, 2016
Fl_Table.cxx: In member function ‘void Fl_Table::recalc_dimensions()’:
Fl_Table.cxx:494:11: warning: suggest parentheses around operand of ‘!’ or change ‘&’ to ‘&&’ or ‘!’ to ‘~’ [-Wparentheses]
     if ( !hideh & hidev ) { hidev = (( table_h - tih + scrollsize ) <= 0 ); }
           ^
Fl_Table.cxx:495:11: warning: suggest parentheses around operand of ‘!’ or change ‘&’ to ‘&&’ or ‘!’ to ‘~’ [-Wparentheses]
     if ( !hidev & hideh ) { hideh = (( table_w - tiw + scrollsize ) <= 0 ); }
           ^
 
 
#2 chris
02:18 Apr 14, 2016
oops: Should be gcc 5.3.1  
 
#3 AlbrechtS
10:03 Oct 17, 2016
Fixed in Subversion repository.

AFAICT this was fixed in svn r11849 "Fix compiler warnings (gcc 6.1)".

-    if ( !hideh & hidev ) { hidev = (( table_h - tih + scrollsize ) <= 0 ); }
-    if ( !hidev & hideh ) { hideh = (( table_w - tiw + scrollsize ) <= 0 ); }
+    if ( !hideh && hidev ) { hidev = (( table_h - tih + scrollsize ) <= 0 ); }
+    if ( !hidev && hideh ) { hideh = (( table_w - tiw + scrollsize ) <= 0 ); }

Can you confirm that the warning is gone?
 
 
#4 chris
03:51 Oct 18, 2016
Yes, warning gone.  
 
#5 AlbrechtS
03:58 Oct 18, 2016
Thanks, closing...  
     

Return to Bugs & Features ]

 
 

Comments are owned by the poster. All other content is copyright 1998-2024 by Bill Spitzak and others. This project is hosted by The FLTK Team. Please report site problems to 'erco@seriss.com'.