FLTK logo

STR #2776

FLTK matrix user chat room
(using Element browser app)   FLTK gitter user chat room   GitHub FLTK Project   FLTK News RSS Feed  
  FLTK Apps      FLTK Library      Forums      Links     Login 
 Home  |  Articles & FAQs  |  Bugs & Features  |  Documentation  |  Download  |  Screenshots  ]
 

Return to Bugs & Features | SVN ⇄ GIT ]

STR #2776

Application:FLTK Library
Status:1 - Closed w/Resolution
Priority:1 - Request for Enhancement, e.g. asking for a feature
Scope:3 - Applies to all machines and operating systems
Subsystem:Core Library
Summary:Separate Fl_Spinner.H to Fl_Spinner.cxx
Version:1.4-feature
Created By:dfatfl
Assigned To:AlbrechtS
Fix Version:1.4.0 (SVN: v12189)
Update Notification:

Receive EMails Don't Receive EMails

Trouble Report Files:


Name/Time/Date Filename/Size  
 
#1 dfatfl
14:39 Nov 21, 2011
separate-spinner.patch
11k
 
 
#2 dfatfl
14:50 Nov 21, 2011
separate-spinner_v2.patch
11k
 
 
#3 dfatfl
16:42 Nov 21, 2011
spinner-blank-allowed.patch
12k
 
     

Trouble Report Comments:


Name/Time/Date Text  
 
#1 dfatfl
14:39 Nov 21, 2011
Separating out to prevent some inlining / code bloat and ability to add enhancements.  
 
#2 dfatfl
16:43 Nov 21, 2011
Posted two addtional files - first one corrects the missing Makefile entry.  The last one adds to the separate version the option to have zero outside the min/max range.  This is useful when you want the values to be optional (!0) but sitll maintain a different range of valid values.  
 
#3 AlbrechtS
16:33 Sep 01, 2016
Bumped version from 1.3-feature to 1.4-feature,
assigned to myself.

This should definitely be done in FLTK 1.4.

Note to myself: remove deprecated methods with spelling errors:

 - maxinum()
 - mininum()
 
 
#4 AlbrechtS
14:18 Mar 09, 2017
Fixed in Subversion repository.

Thanks for the report, BTW, and the patch.

svn r12189 implements the code separation as proposed in separate-spinner_v2.patch, however the code had changed a lot since the patch was posted, so the final solution is different, but hopefully complete.

This commit also removes the deprecated, misspelled methods mininum() and maxinum().

I'm not sure if the additional modifications proposed in spinner-blank-allowed.patch are good/useful for the FLTK library core. Do we need it? Can or should this be done in user code (derived class)? I'm not sure, would like to hear comments.

Otherwise I tend to close this STR with status 'resolved' within two weeks and would like to ask the OP (dfatfl) to comment on this and to open a new STR with a new patch if the functionality is still wanted to keep things simple (one STR, one feature). TIA.
 
 
#5 AlbrechtS
00:40 Aug 02, 2018
The request to separate .H and .cxx has been resolved in svn r12189 (FLTK 1.4.0). We won't update FLTK 1.3.x for this STR because 1.3.x development is closed.

I'm closing this STR now. If you still want the additional features proposed in 'spinner-blank-allowed.patch' please feel free to open a new STR with a sensible title (aka Summary) for FLTK 1.4 and add a patch for current svn (or, maybe git, in the future). Thanks.
 
 
#6 AlbrechtS
00:41 Aug 02, 2018
... however, you might also want to consider deriving your own class with your additional features. Maybe.  
     

Return to Bugs & Features ]

 
 

Comments are owned by the poster. All other content is copyright 1998-2024 by Bill Spitzak and others. This project is hosted by The FLTK Team. Please report site problems to 'erco@seriss.com'.