| [ Return to Bugs & Features | SVN ⇄ GIT ]
STR #2750
Application: | FLTK Library |
Status: | 1 - Closed w/Resolution |
Priority: | 1 - Request for Enhancement, e.g. asking for a feature |
Scope: | 3 - Applies to all machines and operating systems |
Subsystem: | Core Library |
Summary: | Separate Fl_Input_Choice.H to Fl_Input_Choice.cxx |
Version: | 1.4-feature |
Created By: | dfatfl |
Assigned To: | AlbrechtS |
Fix Version: | 1.4.0 (SVN: v12192) |
Update Notification: | |
Trouble Report Files:
Trouble Report Comments:
|
#1 | dfatfl 10:49 Oct 26, 2011 |
| Separated the Fl_Input_Choice.H to ensure certain parts of the code were not inlined (reduce code bloat) and also prepare it for future enhancements. The only change from the released 1.3.0 version is the new maximum_size() convenence function. | |
|
#2 | dfatfl 13:03 Nov 05, 2011 |
| I highly recommended this one be applied ASAP so the patches uploaded relying on it don't become outdated (because it will be hard to see changes for merging) - it simply splits the .H in to both a .cxx and .H file and adds the maximum_size() inline (convenience) function to the .H file. | |
|
#3 | AlbrechtS 08:52 Aug 09, 2016 |
| Moved to 1.4-feature. | |
|
#4 | AlbrechtS 15:37 Mar 11, 2017 |
| Fixed in Subversion repository.
svn r12192 separates Fl_Input_Choice.H and Fl_Input_Choice.cxx but doesn't add the proposed method maximum_size().
This would be a convenience method that is not strictly necessary because input()->maximum_size() would do exactly the same. AFAICT there is no chance that input() could return NULL so the additional NULL pointer check in the proposed method is moot. Please correct me if I'm wrong.
This STR will be closed with status "Resolved" if there are no objections within the next two weeks. | |
|
#5 | AlbrechtS 14:44 Mar 12, 2017 |
| FWIW: uploaded the remaining feature request as maximum_size.patch. | |
|
#6 | AlbrechtS 02:32 Oct 24, 2017 |
| This STR has not been updated by the submitter for two or more weeks and has been closed as required by the FLTK Configuration Management Plan. If the issue still requires resolution, please re-submit a new STR.
I decided not to use the additional maximum_size.patch because there is a simple replacement using input()->maximum_size().
Closing now. | |
[ Return to Bugs & Features ]
|
| |